Feature: add seconds limiter with unitest #168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
liuzengh
added a commit
to trpc-group/cla-database
that referenced
this pull request
Aug 8, 2024
shenh09
changed the title
shenh09
changed the title
Date: Sun Aug 11 22:00:00 2024 +0800 Feature: support seconds limiter - add a fixed time window to implement the second limiter function - at the same time, documentation `doc.md` has been added to explain the feature
shenh09
force-pushed
the
support_seconds_limiter
branch
from
ddd406f to
9e4d50a
Compare
weimch
reviewed
Sep 4, 2024
|
|
||
| namespace trpc::overload_control { | ||
|
|
||
| SecondsOverloadController::SecondsOverloadController(std::string name, int64_t limit, bool is_report, |
There was a problem hiding this comment.
是不是只需要改造一下trpc/overload_control/flow_control模块，让他接入到trpc/overload_control/server_overload_controller.h就好了？没必要拷贝大量重复的代码
|
|
||
| namespace trpc::overload_control { | ||
|
|
||
| SecondsOverloadController::SecondsOverloadController(std::string name, int64_t limit, bool is_report, |
There was a problem hiding this comment.
是不是只需要改造一下trpc/overload_control/flow_control模块，让他接入到trpc/overload_control/server_overload_controller.h就好了？没必要拷贝大量重复的代码
There was a problem hiding this comment.
没理解这里的意思欸，是在trpc/overload_control/flow_control目录下面直接新建文件或者修改原有的文件吗？
There was a problem hiding this comment.
可以看下这个pr，我评论了一下，你看下能否按评论改造下
-Adding reuse -Managing Limiters with Maps -Formatting Documents
|
已经合入完成相同功能点的PR，关闭此PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
完成了 #142 ，实现了固定窗口过载保护插件（我起的名字叫做Seconds Limiter），可以执行
bash /trpc-cpp/test_seconds_limiter.sh启动服务端进行测试, 执行./bazel-bin/examples/helloworld/test/fiber_client --client_config=./examples/helloworld/test/conf/trpc_cpp_fiber.yaml启动客户端进行测试，文档和注释会在之后补充。