Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support circuit breaking for faulty nodes in direct and domain selector modes #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chhy2009
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (fe2471a) 81.83292% compared to head (2dbdfbd) 81.71417%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #113         +/-   ##
===================================================
- Coverage   81.83292%   81.71417%   -0.11876%     
===================================================
  Files            855         868         +13     
  Lines          33924       34174        +250     
===================================================
+ Hits           27761       27925        +164     
- Misses          6163        6249         +86     
Files Coverage Δ
...common/util/circuit_break/bucket_circular_array.cc 100.00000% <100.00000%> (ø)
...mmon/util/circuit_break/circuit_break_whitelist.cc 100.00000% <100.00000%> (ø)
...common/util/circuit_break/circuit_breaker_config.h 100.00000% <100.00000%> (ø)
...il/circuit_break/circuit_breaker_creator_factory.h 100.00000% <100.00000%> (ø)
trpc/naming/direct/direct_selector_conf.h 100.00000% <100.00000%> (ø)
trpc/naming/direct/direct_selector_conf_parser.h 100.00000% <100.00000%> (ø)
trpc/naming/direct/direct_selector_filter.cc 100.00000% <100.00000%> (ø)
trpc/naming/direct/direct_selector_filter.h 92.85714% <ø> (-0.89286%) ⬇️
trpc/naming/direct/selector_direct.h 100.00000% <ø> (ø)
trpc/naming/domain/domain_selector_conf.cc 100.00000% <100.00000%> (ø)
... and 13 more

... and 18 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant