-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not raise Utilityfunction for methods defined in a class_method block #1596
Open
mateusluizfb
wants to merge
4
commits into
troessner:master
Choose a base branch
from
mateusluizfb:support_class_method_block
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1c5bbfb
Do not raise Utilityfunction for methods defined in a class_method block
mateusluizfb e5b3933
Update smell test description
mateusluizfb ee1ca9d
Add new test case to UtilityFunction smell
mateusluizfb f819833
Refactor MethodContext#class_method_block?
mateusluizfb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -177,6 +177,53 @@ def bravo(charlie) | |
end | ||
end | ||
|
||
context 'when examining class_methods block' do | ||
it 'does not report methods defined in class_methods block' do | ||
src = <<-RUBY | ||
module Alpha | ||
extend ActiveSupport::Concern | ||
|
||
class_methods do | ||
def bravo(arg1, arg2) | ||
return 1 if arg1.something? | ||
return 2 if arg2.something_else? | ||
|
||
3 | ||
end | ||
end | ||
end | ||
RUBY | ||
|
||
expect(src).not_to reek_of(:UtilityFunction, context: 'Alpha#bravo') | ||
end | ||
|
||
it 'reports methods defined outside the class_methods block' do | ||
src = <<-RUBY | ||
module Alpha | ||
extend ActiveSupport::Concern | ||
|
||
class_methods do | ||
def bravo(arg1, arg2) | ||
return 1 if arg1.something? | ||
return 2 if arg2.something_else? | ||
|
||
3 | ||
end | ||
end | ||
|
||
def charlie(arg1, arg2) | ||
return 4 if arg1.something? | ||
return 5 if arg2.something_else? | ||
|
||
6 | ||
end | ||
end | ||
RUBY | ||
|
||
expect(src).not_to reek_of(:UtilityFunction, context: 'Alpha#charlie') | ||
end | ||
end | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you also add a test case that shows that methods defined outside the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yup |
||
|
||
describe 'method visibility' do | ||
it 'reports private methods' do | ||
src = <<-RUBY | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mateusluizfb Thanks for this PR!
I have a question about this line.
charlie
is defined outside of theclass_methods do
block.So I would expect it to raise a
UtilityFunction
warning.Can you help me understand why this expectation is a
.not_to reek_of
? Thanks.