Add skeleton codes for dynamic grpc client support #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,71 @@ | |||
| # Copyright 2020-2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
There was a problem hiding this comment.
Suggested change
| # Copyright 2020-2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |
| # Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved. |
Comment on lines
+56
to
+58
| target_link_libraries( | ||
| dgrpc-client-backend-library | ||
| ) |
There was a problem hiding this comment.
This isn't necessary since you're not listing any libraries:
https://cmake.org/cmake/help/latest/command/target_link_libraries.html#overview
| InferStat infer_stat_; | ||
|
|
||
| private: | ||
| Error PreRunProcessing( |
There was a problem hiding this comment.
Nit: this isn't inheriting from an interface, there's no technical need to have a function with this name.
I don't really understand the original use of this that's why I'm slightly pushing back on continuing its use.
|
(Accidental closure--reopened) |
Thanks for catching and fixing this, Matt! Apologies for the accidental closure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds skeleton codes for dynamic grpc client support. It declares all (or most) of the necessary classes that client backend needs with empty definitions. The code successfully compiles but does not work yet. Next few PRs will fill in the contents of the class function bodies.
New classes added are:
DynamicGrpcClientBackendDynamicGrpcInferRequestedOutputDynamicGrpcInferInputDynamicGrpcClientDynamicGrpcRequestDynamicGrpcInferResultAlso added
DYNAMIC_GRPCInitDynamicGrpc)