Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toggling returns visible value #73

Merged
merged 2 commits into from
Jun 16, 2024
Merged

Conversation

osamuaoki
Copy link
Contributor

@osamuaoki osamuaoki commented Jun 16, 2024

Here is my first try with code changes and document updates in 2 commits.

In order to be consistent, I added return value for all toggle, show, and hide; but not for peek.

Let me know if you want to limit changes to toggle only.

closes #72

@tris203 tris203 changed the title Return visible feat: toggling returns visible value Jun 16, 2024
Copy link
Owner

@tris203 tris203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should just be scoped to the toggle command

The value of the show and hide values is implied

@osamuaoki
Copy link
Contributor Author

Done and force-pushed

@tris203 tris203 merged commit 6aab38a into tris203:main Jun 16, 2024
10 checks passed
@tris203
Copy link
Owner

tris203 commented Jun 16, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request - Expose visible value as subcommand
2 participants