Add newTrinoTable method to AbstractTestQueryFramework
#24337
Merged
+470
−628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
iceberg
ebyhr
added
maintenance
hashhar
reviewed
Dec 10, 2024
Comment on lines
672
to
680
| protected TestTable createTable(String namePrefix, @Language("SQL") String tableDefinition) | ||
| { | ||
| return createTable(namePrefix, tableDefinition, ImmutableList.of()); | ||
| } | ||
|
|
||
| protected TestTable createTable(String namePrefix, @Language("SQL") String tableDefinition, List<String> rowsToInsert) | ||
| { | ||
| return new TestTable(getQueryRunner()::execute, namePrefix, tableDefinition, rowsToInsert); | ||
| } |
There was a problem hiding this comment.
nit: one thing I liked about the old was it made clear which executor is used to create table - maybe the method name should be createTableUsingTrino or something to clarify this?
This is a not a big deal so feel free to ignore.
There was a problem hiding this comment.
I want to use shorter name here. How about newTrinoTable?
ebyhr
changed the title
newTrinoTable method to AbstractTestQueryFramework
hashhar
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.