Add missing type annotations for the "TrinoRequest" class #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturdryomov
commented
Dec 19, 2024
| @@ -33,7 +33,7 @@ | |||
| from requests.auth import extract_cookies_to_jar | |||
|
|
|||
| import trino.logging | |||
| from trino.client import exceptions | |||
| from trino import exceptions | |||
There was a problem hiding this comment.
Without this change:
ImportError while importing test module 'trino-python-client/tests/unit/test_types.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../.cache/pyenv/versions/3.9.21/lib/python3.9/importlib/__init__.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
tests/unit/test_types.py:19: in <module>
from trino import types
trino/__init__.py:12: in <module>
from . import auth
trino/auth.py:36: in <module>
from trino.client import exceptions
trino/client.py:67: in <module>
from trino.auth import Authentication
E ImportError: cannot import name 'Authentication' from partially initialized module 'trino.auth' (most likely due to a circular import) (trino-python-client/trino/auth.py)
Makes sense but not sure why trino.client was referred for exceptions in the first place.
There was a problem hiding this comment.
It was a mistake since the beginning - 5cd6523#diff-6db3a24c52bc43426976f516411e7de756f5ee0f8f3904ca036da682aeaa840c
Thanks for noticing and fixing.
hashhar
approved these changes
Jan 2, 2025
This was incorrect from the beginning since 5cd6523.
hashhar
force-pushed
the
ad/types-trino-request
branch
from
a8d19c5 to
9617a51
Compare
|
reordered and reworded a bit, will merge on CI. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type annotations for the
client.TrinoRequestclass based on usages and tests.Release notes
Release notes are required, with the following suggested text: