Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Placeholder type updates #85

Merged
merged 1 commit into from
Jun 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: gridpattern
Type: Package
Title: 'grid' Pattern Grobs
Version: 1.2.2-0
Version: 1.2.2
Authors@R: c(
person("Trevor L.", "Davis", role=c("aut", "cre"), email="[email protected]",
comment = c(ORCID = "0000-0001-6341-4639")),
Expand Down
19 changes: 17 additions & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
gridpattern v1.2.2 (development)
================================
gridpattern v1.2.2
==================

Bug fixes and minor improvements
--------------------------------
Expand All @@ -11,6 +11,21 @@ Bug fixes and minor improvements
* For the "polygon\_tiling" pattern `type = "18.18.3*"` the size of the
eighteen-sided polygons have been increased a teeny bit and
this polygon tiling should look a bit cleaner.
* The following "placeholder" pattern updates (#83):

+ The following placeholder pattern names are now serviced by lucidinternets.com:

- "cage" and "cagebw"
- "murray" and "murraybw"
- "seagal" and "seagalbw"

+ The following placeholder pattern names have been removed since their associated web service no longer works:

- "lorempixel" and "lorempixelbw" (service unavailable since 2022)
- "placeimg" and "placeimgbw" ([support officially ended July 2023](https://www.gomasuga.com/placeimg?souce=placeimg))

+ The "dummybw" name now provides a pure black-and-white image (i.e. no grey).
+ Fixes a regression for the "placeholderbw" name where it redirected to the "segal" name instead of "placeholder".

gridpattern v1.2.1
==================
Expand Down
51 changes: 21 additions & 30 deletions R/pattern-array-placeholder.R
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,13 @@ names_placeholder <- c(
"bear", "bearbw",
"beard", "beardbw",
"cage", "cagebw",
"dummybw", "dummy",
"dummy", "dummybw",
"flickr", "flickrbw",
"keanu", "keanubw",
"kitten", "kittenbw",
"lorempixel", "lorempixelbw",
"murray", "murraybw",
"picsum", "picsumbw",
"placeholder", "placeholderbw",
"placeimg", "placeimgbw",
"seagal", "seagalbw"
)

Expand All @@ -55,24 +53,22 @@ names_placeholder <- c(
#' 'bw' to the name to fetch greyscale images instead of colour.
#'
#' \describe{
#' \item{\code{kitten}}{ - Kittens from \url{https://placekitten.com/}}
#' \item{\code{picsum}}{ - Random images from \url{https://picsum.photos/}}
#' \item{\code{murray}}{ - Bill Murrary images from \url{http://www.fillmurray.com}}
#' \item{\code{cage}}{ - Nicholas Cage images from \url{https://www.placecage.com/}}
#' \item{\code{beard}}{ - Beards! \url{https://placebeard.it/}}
#' \item{\code{bear}}{ - Bears from \url{https://placebear.com/}}
#' \item{\code{seagal}}{ - Steven Seagal images from \url{https://www.stevensegallery.com/}}
#' \item{\code{flickr}}{ - Images from Flickr \url{https://loremflickr.com/}}
#' \item{\code{beard}}{ - Beards! \url{http://placebeard.it/}}
#' \item{\code{lorempixel}}{ - Random images from \url{http://lorempixel.com/}}
#' \item{\code{placeimg}}{ - Random images from \url{http://placeimg.com/}}
#' \item{\code{cage}}{ - Nicholas Cage images from \url{https://placecage.lucidinternets.com}}
#' \item{\code{dummy}}{ - Numeric placeholder images from \url{https://dummyimage.com}}
#' \item{\code{flickr}}{ - Images from Flickr \url{https://loremflickr.com/}}
#' \item{\code{kitten}}{ - Kittens from \url{https://placekitten.com/}}
#' \item{\code{murray}}{ - Bill Murrary images from \url{https://fillmurray.lucidinternets.com}}
#' \item{\code{picsum}}{ - Random images from \url{https://picsum.photos/}}
#' \item{\code{seagal}}{ - Steven Seagal images from \url{https://stevensegallery.lucidinternets.com/}}
#' }
#'
#' @param width,height image dimensions
#' @param type specify the server from which to fetch images. default: 'kitten'
#'
#' @noRd
fetch_placeholder_img <- function(width = 100, height = 100, type = 'kitten') {
fetch_placeholder_img <- function(width = 100, height = 100, type = 'dummy') {

width <- as.integer(width)
height <- as.integer(height)
Expand All @@ -81,34 +77,29 @@ fetch_placeholder_img <- function(width = 100, height = 100, type = 'kitten') {
type,
bear = glue("https://placebear.com/{width}/{height}"),
bearbw = glue("https://placebear.com/g/{width}/{height}"),
beard = glue("http://placebeard.it/{width}/{height}"),
beardbw = glue("http://placebeard.it/g/{width}/{height}"),
cage = glue("https://www.placecage.com/{width}/{height}"),
cagebw = glue("https://www.placecage.com/g/{width}/{height}"),
beard = glue("https://placebeard.it/{width}/{height}"),
beardbw = glue("https://placebeard.it/g/{width}/{height}"),
cage = glue("https://placecage.lucidinternets.com/{width}/{height}"),
cagebw = glue("https://placecage.lucidinternets.com/g/{width}/{height}"),
dummy = glue("https://dummyimage.com/{width}x{height}"),
dummybw = ,
dummybw = glue("https://dummyimage.com/{width}x{height}/fff/000"),
flickr = glue("https://loremflickr.com/{width}/{height}"),
flickrbw = glue("https://loremflickr.com/g/{width}/{height}/all"),
keanu = glue("https://placekeanu.com/{width}/{height}"),
keanubw = glue("https://placekeanu.com/{width}/{height}/g"),
kitten = glue("https://placekitten.com/{width}/{height}"),
kittenbw = glue("https://placekitten.com/g/{width}/{height}"),
lorempixel = glue("http://lorempixel.com/{width}/{height}"),
lorempixelbw = glue("http://lorempixel.com/g/{width}/{height}"),
murray = glue("http://www.fillmurray.com/{width}/{height}"),
murraybw = glue("http://www.fillmurray.com/g/{width}/{height}"),
murray = glue("https://fillmurray.lucidinternets.com/{width}/{height}"),
murraybw = glue("https://fillmurray.lucidinternets.com/g/{width}/{height}"),
picsum = glue("https://picsum.photos/{width}/{height}"),
picsumbw = glue("https://picsum.photos/{width}/{height}?grayscale"),
placeholder = glue("https://via.placeholder.com/{width}x{height}.png"),
placeholderbw = ,
placeimg = glue("http://placeimg.com/{width}/{height}/any"),
placeimgbw = glue("http://placeimg.com/{width}/{height}/any/grayscale"),
seagal = glue("https://www.stevensegallery.com/{width}/{height}"),
seagalbw = glue("https://www.stevensegallery.com/g/{width}/{height}"),
placeholder = glue("https://via.placeholder.com/{width}x{height}.png"),
seagal = glue("https://www.stevensegallery.lucidinternets.com/{width}/{height}"),
seagalbw = glue("https://www.stevensegallery.lucidinternets.com/g/{width}/{height}"),
{
# warn("fetch_placeholder_image_as_array(): Unknown pattern_type (", type, ") ",
# "using 'kitten'")
glue("https://placekitten.com/{width}/{height}")
warn(glue("Unknown placeholder type '{type}' using 'bear' instead"))
glue("https://dummyimage.com/{width}x{height}")
}
)

Expand Down
2 changes: 2 additions & 0 deletions _pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ destination: "../../websites/R/gridpattern/"
url: "https://trevorldavis.com/R/gridpattern"
development:
mode: auto
template:
bootstrap: 5
reference:
- title: "Pattern fills"
desc: "Pattern fill function"
Expand Down
2 changes: 1 addition & 1 deletion man/grid.pattern_placeholder.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.