Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade tests/tor.bats for deleteall and destroy (fixes #2211) #2212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JLKwong
Copy link
Member

@JLKwong JLKwong commented Apr 19, 2021

No description provided.

@JLKwong JLKwong requested a review from rjpadilla April 19, 2021 08:33
@@ -48,6 +48,7 @@ load test-helper
}

@test "$clinom tor add 22" {
run "${clicmd}" tor add 22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line kinda redundant?

Copy link
Member

@rjpadilla rjpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I ran the tests and it passed them all..
But it deleted my tor ports 😭
torlistgone
If that's the purpose of the function and theres no way of changing it I'll approve this, but it'll be really nice if we could've kept our ports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants