Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update /tests/wificountry.bats (fixes #2165) #2166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update /tests/wificountry.bats (fixes #2165) #2166

wants to merge 1 commit into from

Conversation

rjpadilla
Copy link
Member

No description provided.

JLKwong
JLKwong requested changes Apr 9, 2021
View reviewed changes
Copy link
Member

@JLKwong JLKwong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also test for setting the wifi country to additional countries other than the US (e.g. SO, DE, etc.)

(The last test should test for US so that the pi stays in the US wifi country.)

tests/wificountry.bats Show resolved Hide resolved
@rjpadilla
Copy link
Member Author

You could also test for setting the wifi country to additional countries other than the US (e.g. SO, DE, etc.)

(The last test should test for US so that the pi stays in the US wifi country.)

I looked more deep into this and it looks we can add Somalia (no UK or EU though). I made it into an issue #2184

JLKwong
JLKwong approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@JLKwong JLKwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New WiFi country codes will be added in #2184 :

#2184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLKwong JLKwong JLKwong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjpadilla @JLKwong