adding new feature to treehouses message discord
#2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLKwong
requested changes
Mar 26, 2021
| else | ||
| log_comment_and_exit1 "ERROR: message not delivered" | ||
| fi | ||
| ;; | ||
| *) | ||
| log_help_and_exit1 "Error: This command does not exist" message |
There was a problem hiding this comment.
Error message could be updated to explicitly list all the Discord commands that exist.
There was a problem hiding this comment.
I'm still in the rough draft stages >.<
| @@ -509,6 +509,42 @@ function message { | |||
| echo "you have successfully authorized and your access token is $access_token " | |||
| fi | |||
| ;; | |||
| webhook) | |||
There was a problem hiding this comment.
Could echo error message if webhook and/or apitoken isn't provided:
e.g.
Error: Please add a webhook URL.
|
|
||
| echo "Your webhook url is $webhook_url" | ||
| ;; | ||
| send) |
There was a problem hiding this comment.
Should account for empty messages. Empty messages generate this error:
line 542: {"message":: command not found
ERROR: message not delivered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature:
webhookpulls info from the Discord API.sendsends a message to your selected discord channel.Can add multiple channels.