Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JwtPlugin fixes #138

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

sseppola
Copy link

@sseppola sseppola commented Feb 7, 2022

This PR depends on #133, which I'm keen to work with you to resolve.

While trying to implement JWT auth we had some issues

  • Added a bunch of debug logs
  • JwtPlugin now runs access_token assertions if defined
  • got confused by all the config variables, renamed jwtConfig for clarity

Edit: We also got an issue "id_token detected in the response, you must use client.callback() instead of client.oauthCallback()". Commit bb5541a fixes that in the OAuth plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant