function added to print paths from source to destination with the shortest number of link #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, have you reviewed the code yet? Please let me know if anything needs to be done |
tranlv
reviewed
Jul 10, 2019
tranlv
reviewed
Jul 12, 2019
tranlv
reviewed
Jul 13, 2019
| @@ -525,3 +570,26 @@ def _insert_link(session, from_page_id, to_page_id, no_of_separation): | |||
| "Many rows found in DB to store link from {} to {}\ | |||
| with number of seperation {}".format(from_page_id, to_page_id, | |||
| no_of_separation)) | |||
|
|
|||
There was a problem hiding this comment.
So by convention, we separate 2 functions by 2 empty lines
| def get_url_path_from_page_ids(session, page_ids_list): | ||
| path_url = [] | ||
| for page_id in page_ids_list: | ||
| page_url = session.query(Page).filter(Page.id == page_id).first() |
There was a problem hiding this comment.
For DB operation, please consider to add try/except, i.e. in case DB connection failure
| successful_paths = [] | ||
|
|
||
| with self._session_scope() as session: | ||
| def find_route_to_parent(node, source_root_id, depth=0, session=session): |
There was a problem hiding this comment.
So what happens if 2 links are parents of each other, i.e. url of 1 can be found from the other wiki page and vice versal; this will create an infinite loop and running out of limit soon
There was a problem hiding this comment.
We are having check on the depth with limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added function _print_path to print path from source to destination.
The logic used is to backtrack from destination id to source id and print the shortest path.