Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

400 tf24 hydraulics merge existing leaf model with tests #433

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

itowers1
Copy link
Collaborator

@itowers1 itowers1 commented Jul 1, 2024

Adding the leaf model into develop. This includes the leaf model .cpp and .h and documentation for the leaf model. It introduces a range of functions that are accessible once the leaf object is constructed. The leaf submodel is not currentlty accessed by any other element in plant but will eventually be connected to tf24 strategy.

@itowers1 itowers1 requested a review from dfalster July 1, 2024 00:51
@itowers1 itowers1 linked an issue Jul 1, 2024 that may be closed by this pull request
2 tasks
@dfalster
Copy link
Member

dfalster commented Jul 1, 2024

Nice work @itowers1 . It looks like the various generated files haven't been committed. So the results of running make rebuild. We did do that on Friday so not sure why they're not here,. perhaps you didn't commit those?

@itowers1
Copy link
Collaborator Author

itowers1 commented Jul 1, 2024

My mistake available now

Copy link
Member

@dfalster dfalster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @itowers1 !

I edited the vignette a little, as wasn't quite working. Good to go now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TF24 hydraulics: Merge existing leaf model with tests
2 participants