Skip to content
This repository has been archived by the owner on Aug 15, 2023. It is now read-only.

feat: metadata logger for extension #663

Open
wants to merge 2 commits into
base: daily
Choose a base branch
from
Open

feat: metadata logger for extension #663

wants to merge 2 commits into from

Conversation

ascariandrea
Copy link
Collaborator

@ascariandrea ascariandrea commented Sep 19, 2022 •
edited
Loading

Here's a POC for a MetadataLogger component that gives a real time feedback for the collected contributions, with the expected metadata.

Screenshot from 2022-09-27 17-00-14

At the moment the component misses a few things:

  • list more the one results
  • some interactions i.e.: repeat / ignore / delete
  • a nice UI

With the adding of the storybook #683 it would be easier to polish the UI - and fix the behaviour - without having to load & watch the extension in the browser.

@ascariandrea ascariandrea marked this pull request as draft September 19, 2022 10:50
@ascariandrea ascariandrea force-pushed the fix/metadata-parser-in-extension branch 2 times, most recently from bd8adaa to 1a9eb9a Compare September 19, 2022 11:06
@ascariandrea ascariandrea changed the base branch from daily to refactor/shared-parsers September 27, 2022 14:47
@vecna
Copy link
Member

vecna commented Sep 27, 2022

@ascariandrea ascariandrea force-pushed the fix/metadata-parser-in-extension branch 2 times, most recently from 401395c to dc4937b Compare September 27, 2022 16:13
@ascariandrea ascariandrea linked an issue Sep 29, 2022 that may be closed by this pull request
[shared:extension] Metadata UI Logger component #679
Open
@ascariandrea ascariandrea force-pushed the refactor/shared-parsers branch 4 times, most recently from 10f526f to 289784a Compare September 29, 2022 12:48
@ascariandrea ascariandrea force-pushed the fix/metadata-parser-in-extension branch 3 times, most recently from 45aeafe to 294f813 Compare September 29, 2022 15:21
@vecna
Copy link
Member

vecna commented Sep 29, 2022

Hi @ascariandrea a two small problems happening on my testing:

  1. the recommendation were taking longer to load, hence, the parser has failed. this might be a non problem (but perhaps in the MetadataLogger we can also put an icon to re-parse ? )
  2. somehow it is mentioned a search in the box in the MetadataLogger even if I was testing on a video
  3. also the MetadataLogger feature can't run at all if the backend isn't working, it remind me the same issue as [shared:extension] when an extension find an HTTP error in the background window should communicate it visually #580

image

@ascariandrea ascariandrea changed the base branch from fix/yt-nature-parser to fix/tk-profile-parser October 4, 2022 14:09
@ascariandrea ascariandrea force-pushed the fix/metadata-parser-in-extension branch from cfa0f5b to a62a585 Compare October 4, 2022 14:24
@ascariandrea ascariandrea force-pushed the fix/tk-profile-parser branch 4 times, most recently from d5c15ac to db2f9ed Compare October 4, 2022 16:29
@ascariandrea ascariandrea force-pushed the fix/metadata-parser-in-extension branch from a62a585 to 2710720 Compare October 4, 2022 16:30
@ascariandrea ascariandrea force-pushed the fix/tk-profile-parser branch 5 times, most recently from c6ce410 to fef5689 Compare October 5, 2022 12:22
Base automatically changed from fix/tk-profile-parser to daily October 6, 2022 08:35
@ascariandrea ascariandrea force-pushed the fix/metadata-parser-in-extension branch from 2710720 to b6c4816 Compare October 10, 2022 09:21
@ascariandrea ascariandrea marked this pull request as ready for review October 10, 2022 11:06
@ascariandrea ascariandrea force-pushed the fix/metadata-parser-in-extension branch 2 times, most recently from 912bcba to 39cabf5 Compare October 10, 2022 13:43
@ascariandrea ascariandrea force-pushed the fix/metadata-parser-in-extension branch from 39cabf5 to e95b751 Compare October 11, 2022 10:35
@ascariandrea ascariandrea force-pushed the fix/metadata-parser-in-extension branch 2 times, most recently from b88bbd8 to bec0a28 Compare October 27, 2022 11:51
dependabot bot and others added 2 commits November 15, 2022 10:09
@dependabot @ascariandrea
build(deps): bump loader-utils from 1.4.0 to 1.4.1
7ca77e4 
Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md)
- [Commits](webpack/loader-utils@v1.4.0...v1.4.1)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@ascariandrea
fix(shared): added metadata logger box to extension
5affd6a
@ascariandrea ascariandrea force-pushed the fix/metadata-parser-in-extension branch from bec0a28 to 5affd6a Compare November 15, 2022 11:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rekoke rekoke Awaiting requested review from rekoke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[shared:extension] Metadata UI Logger component
2 participants
@ascariandrea @vecna