-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable KLib ABI validation #402
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
// Klib ABI Dump | ||
// Targets: [iosArm64, iosSimulatorArm64, iosX64, macosArm64, macosX64, tvosArm64, tvosSimulatorArm64, tvosX64, watchosArm32, watchosArm64, watchosDeviceArm64, watchosSimulatorArm64, watchosX64] | ||
// Rendering settings: | ||
// - Signature version: 2 | ||
// - Show manifest properties: true | ||
// - Show declarations: true | ||
|
||
// Library unique name: <co.touchlab:kermit-bugsnag> |
8 changes: 8 additions & 0 deletions
8
extensions/kermit-crashlytics/api/kermit-crashlytics.klib.api
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
// Klib ABI Dump | ||
// Targets: [iosArm64, iosSimulatorArm64, iosX64, macosArm64, macosX64, tvosArm64, tvosSimulatorArm64, tvosX64, watchosArm32, watchosArm64, watchosDeviceArm64, watchosSimulatorArm64, watchosX64] | ||
// Rendering settings: | ||
// - Signature version: 2 | ||
// - Show manifest properties: true | ||
// - Show declarations: true | ||
|
||
// Library unique name: <co.touchlab:kermit-crashlytics> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// Klib ABI Dump | ||
// Targets: [iosArm64, iosSimulatorArm64, iosX64, js, linuxX64, macosArm64, macosX64, mingwX64, tvosArm64, tvosSimulatorArm64, tvosX64, watchosArm64, watchosSimulatorArm64, watchosX64] | ||
// Rendering settings: | ||
// - Signature version: 2 | ||
// - Show manifest properties: true | ||
// - Show declarations: true | ||
|
||
// Library unique name: <co.touchlab:kermit-koin> | ||
final class co.touchlab.kermit.koin/KermitKoinLogger : org.koin.core.logger/Logger { // co.touchlab.kermit.koin/KermitKoinLogger|null[0] | ||
constructor <init>(co.touchlab.kermit/Logger) // co.touchlab.kermit.koin/KermitKoinLogger.<init>|<init>(co.touchlab.kermit.Logger){}[0] | ||
|
||
final fun display(org.koin.core.logger/Level, kotlin/String) // co.touchlab.kermit.koin/KermitKoinLogger.display|display(org.koin.core.logger.Level;kotlin.String){}[0] | ||
} | ||
|
||
final fun co.touchlab.kermit.koin/kermitLoggerModule(co.touchlab.kermit/Logger): org.koin.core.module/Module // co.touchlab.kermit.koin/kermitLoggerModule|kermitLoggerModule(co.touchlab.kermit.Logger){}[0] | ||
final inline fun <#A: reified co.touchlab.kermit/Logger> (org.koin.core.scope/Scope).co.touchlab.kermit.koin/getLoggerWithTag(kotlin/String): #A // co.touchlab.kermit.koin/getLoggerWithTag|[email protected](kotlin.String){0§<co.touchlab.kermit.Logger>}[0] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
// Klib ABI Dump | ||
// Targets: [androidNativeArm32, androidNativeArm64, androidNativeX64, androidNativeX86, iosArm64, iosSimulatorArm64, iosX64, js, linuxArm64, linuxX64, macosArm64, macosX64, mingwX64, tvosArm64, tvosSimulatorArm64, tvosX64, wasmJs, watchosArm32, watchosArm64, watchosDeviceArm64, watchosSimulatorArm64, watchosX64] | ||
// Rendering settings: | ||
// - Signature version: 2 | ||
// - Show manifest properties: true | ||
// - Show declarations: true | ||
|
||
// Library unique name: <co.touchlab:kermit-simple> | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/a(kotlin/Function0<kotlin/String>) // co.touchlab.kermit/a|[email protected](kotlin.Function0<kotlin.String>){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/a(kotlin/String) // co.touchlab.kermit/a|[email protected](kotlin.String){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/a(kotlin/String, kotlin/Throwable) // co.touchlab.kermit/a|[email protected](kotlin.String;kotlin.Throwable){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/a(kotlin/Throwable, kotlin/Function0<kotlin/String>) // co.touchlab.kermit/a|[email protected](kotlin.Throwable;kotlin.Function0<kotlin.String>){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/d(kotlin/Function0<kotlin/String>) // co.touchlab.kermit/d|[email protected](kotlin.Function0<kotlin.String>){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/d(kotlin/String) // co.touchlab.kermit/d|[email protected](kotlin.String){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/d(kotlin/String, kotlin/Throwable) // co.touchlab.kermit/d|[email protected](kotlin.String;kotlin.Throwable){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/d(kotlin/Throwable, kotlin/Function0<kotlin/String>) // co.touchlab.kermit/d|[email protected](kotlin.Throwable;kotlin.Function0<kotlin.String>){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/e(kotlin/Function0<kotlin/String>) // co.touchlab.kermit/e|[email protected](kotlin.Function0<kotlin.String>){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/e(kotlin/String) // co.touchlab.kermit/e|[email protected](kotlin.String){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/e(kotlin/String, kotlin/Throwable) // co.touchlab.kermit/e|[email protected](kotlin.String;kotlin.Throwable){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/e(kotlin/Throwable, kotlin/Function0<kotlin/String>) // co.touchlab.kermit/e|[email protected](kotlin.Throwable;kotlin.Function0<kotlin.String>){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/i(kotlin/Function0<kotlin/String>) // co.touchlab.kermit/i|[email protected](kotlin.Function0<kotlin.String>){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/i(kotlin/String) // co.touchlab.kermit/i|[email protected](kotlin.String){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/i(kotlin/String, kotlin/Throwable) // co.touchlab.kermit/i|[email protected](kotlin.String;kotlin.Throwable){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/i(kotlin/Throwable, kotlin/Function0<kotlin/String>) // co.touchlab.kermit/i|[email protected](kotlin.Throwable;kotlin.Function0<kotlin.String>){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/v(kotlin/Function0<kotlin/String>) // co.touchlab.kermit/v|[email protected](kotlin.Function0<kotlin.String>){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/v(kotlin/String) // co.touchlab.kermit/v|[email protected](kotlin.String){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/v(kotlin/String, kotlin/Throwable) // co.touchlab.kermit/v|[email protected](kotlin.String;kotlin.Throwable){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/v(kotlin/Throwable, kotlin/Function0<kotlin/String>) // co.touchlab.kermit/v|[email protected](kotlin.Throwable;kotlin.Function0<kotlin.String>){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/w(kotlin/Function0<kotlin/String>) // co.touchlab.kermit/w|[email protected](kotlin.Function0<kotlin.String>){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/w(kotlin/String) // co.touchlab.kermit/w|[email protected](kotlin.String){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/w(kotlin/String, kotlin/Throwable) // co.touchlab.kermit/w|[email protected](kotlin.String;kotlin.Throwable){}[0] | ||
final fun (co.touchlab.kermit/Logger).co.touchlab.kermit/w(kotlin/Throwable, kotlin/Function0<kotlin/String>) // co.touchlab.kermit/w|[email protected](kotlin.Throwable;kotlin.Function0<kotlin.String>){}[0] | ||
final fun co.touchlab.kermit/a(kotlin/Function0<kotlin/String>) // co.touchlab.kermit/a|a(kotlin.Function0<kotlin.String>){}[0] | ||
final fun co.touchlab.kermit/a(kotlin/String) // co.touchlab.kermit/a|a(kotlin.String){}[0] | ||
final fun co.touchlab.kermit/a(kotlin/String, kotlin/Throwable) // co.touchlab.kermit/a|a(kotlin.String;kotlin.Throwable){}[0] | ||
final fun co.touchlab.kermit/a(kotlin/Throwable, kotlin/Function0<kotlin/String>) // co.touchlab.kermit/a|a(kotlin.Throwable;kotlin.Function0<kotlin.String>){}[0] | ||
final fun co.touchlab.kermit/d(kotlin/Function0<kotlin/String>) // co.touchlab.kermit/d|d(kotlin.Function0<kotlin.String>){}[0] | ||
final fun co.touchlab.kermit/d(kotlin/String) // co.touchlab.kermit/d|d(kotlin.String){}[0] | ||
final fun co.touchlab.kermit/d(kotlin/String, kotlin/Throwable) // co.touchlab.kermit/d|d(kotlin.String;kotlin.Throwable){}[0] | ||
final fun co.touchlab.kermit/d(kotlin/Throwable, kotlin/Function0<kotlin/String>) // co.touchlab.kermit/d|d(kotlin.Throwable;kotlin.Function0<kotlin.String>){}[0] | ||
final fun co.touchlab.kermit/e(kotlin/Function0<kotlin/String>) // co.touchlab.kermit/e|e(kotlin.Function0<kotlin.String>){}[0] | ||
final fun co.touchlab.kermit/e(kotlin/String) // co.touchlab.kermit/e|e(kotlin.String){}[0] | ||
final fun co.touchlab.kermit/e(kotlin/String, kotlin/Throwable) // co.touchlab.kermit/e|e(kotlin.String;kotlin.Throwable){}[0] | ||
final fun co.touchlab.kermit/e(kotlin/Throwable, kotlin/Function0<kotlin/String>) // co.touchlab.kermit/e|e(kotlin.Throwable;kotlin.Function0<kotlin.String>){}[0] | ||
final fun co.touchlab.kermit/i(kotlin/Function0<kotlin/String>) // co.touchlab.kermit/i|i(kotlin.Function0<kotlin.String>){}[0] | ||
final fun co.touchlab.kermit/i(kotlin/String) // co.touchlab.kermit/i|i(kotlin.String){}[0] | ||
final fun co.touchlab.kermit/i(kotlin/String, kotlin/Throwable) // co.touchlab.kermit/i|i(kotlin.String;kotlin.Throwable){}[0] | ||
final fun co.touchlab.kermit/i(kotlin/Throwable, kotlin/Function0<kotlin/String>) // co.touchlab.kermit/i|i(kotlin.Throwable;kotlin.Function0<kotlin.String>){}[0] | ||
final fun co.touchlab.kermit/v(kotlin/Function0<kotlin/String>) // co.touchlab.kermit/v|v(kotlin.Function0<kotlin.String>){}[0] | ||
final fun co.touchlab.kermit/v(kotlin/String) // co.touchlab.kermit/v|v(kotlin.String){}[0] | ||
final fun co.touchlab.kermit/v(kotlin/String, kotlin/Throwable) // co.touchlab.kermit/v|v(kotlin.String;kotlin.Throwable){}[0] | ||
final fun co.touchlab.kermit/v(kotlin/Throwable, kotlin/Function0<kotlin/String>) // co.touchlab.kermit/v|v(kotlin.Throwable;kotlin.Function0<kotlin.String>){}[0] | ||
final fun co.touchlab.kermit/w(kotlin/Function0<kotlin/String>) // co.touchlab.kermit/w|w(kotlin.Function0<kotlin.String>){}[0] | ||
final fun co.touchlab.kermit/w(kotlin/String) // co.touchlab.kermit/w|w(kotlin.String){}[0] | ||
final fun co.touchlab.kermit/w(kotlin/String, kotlin/Throwable) // co.touchlab.kermit/w|w(kotlin.String;kotlin.Throwable){}[0] | ||
final fun co.touchlab.kermit/w(kotlin/Throwable, kotlin/Function0<kotlin/String>) // co.touchlab.kermit/w|w(kotlin.Throwable;kotlin.Function0<kotlin.String>){}[0] | ||
final fun co.touchlab.kermit/withTag(kotlin/String): co.touchlab.kermit/Logger // co.touchlab.kermit/withTag|withTag(kotlin.String){}[0] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
// Klib ABI Dump | ||
// Targets: [androidNativeArm32, androidNativeArm64, androidNativeX64, androidNativeX86, iosArm64, iosSimulatorArm64, iosX64, js, linuxArm64, linuxX64, macosArm64, macosX64, mingwX64, tvosArm64, tvosSimulatorArm64, tvosX64, wasmJs, watchosArm32, watchosArm64, watchosDeviceArm64, watchosSimulatorArm64, watchosX64] | ||
// Rendering settings: | ||
// - Signature version: 2 | ||
// - Show manifest properties: true | ||
// - Show declarations: true | ||
|
||
// Library unique name: <co.touchlab:kermit-test> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
// Klib ABI Dump | ||
// Targets: [androidNativeArm32, androidNativeArm64, androidNativeX64, androidNativeX86, iosArm64, iosSimulatorArm64, iosX64, js, linuxArm64, linuxX64, macosArm64, macosX64, mingwX64, tvosArm64, tvosSimulatorArm64, tvosX64, wasmJs, watchosArm32, watchosArm64, watchosDeviceArm64, watchosSimulatorArm64, watchosX64] | ||
// Rendering settings: | ||
// - Signature version: 2 | ||
// - Show manifest properties: true | ||
// - Show declarations: true | ||
|
||
// Library unique name: <co.touchlab:kermit> | ||
open class co.touchlab.kermit/Logger : co.touchlab.kermit/BaseLogger { // co.touchlab.kermit/Logger|null[0] | ||
constructor <init>(co.touchlab.kermit/LoggerConfig, kotlin/String =...) // co.touchlab.kermit/Logger.<init>|<init>(co.touchlab.kermit.LoggerConfig;kotlin.String){}[0] | ||
|
||
open val tag // co.touchlab.kermit/Logger.tag|{}tag[0] | ||
open fun <get-tag>(): kotlin/String // co.touchlab.kermit/Logger.tag.<get-tag>|<get-tag>(){}[0] | ||
|
||
final fun withTag(kotlin/String): co.touchlab.kermit/Logger // co.touchlab.kermit/Logger.withTag|withTag(kotlin.String){}[0] | ||
final inline fun a(kotlin/String, kotlin/Throwable? =..., kotlin/String =...) // co.touchlab.kermit/Logger.a|a(kotlin.String;kotlin.Throwable?;kotlin.String){}[0] | ||
final inline fun a(kotlin/Throwable? =..., kotlin/String =..., kotlin/Function0<kotlin/String>) // co.touchlab.kermit/Logger.a|a(kotlin.Throwable?;kotlin.String;kotlin.Function0<kotlin.String>){}[0] | ||
final inline fun d(kotlin/String, kotlin/Throwable? =..., kotlin/String =...) // co.touchlab.kermit/Logger.d|d(kotlin.String;kotlin.Throwable?;kotlin.String){}[0] | ||
final inline fun d(kotlin/Throwable? =..., kotlin/String =..., kotlin/Function0<kotlin/String>) // co.touchlab.kermit/Logger.d|d(kotlin.Throwable?;kotlin.String;kotlin.Function0<kotlin.String>){}[0] | ||
final inline fun e(kotlin/String, kotlin/Throwable? =..., kotlin/String =...) // co.touchlab.kermit/Logger.e|e(kotlin.String;kotlin.Throwable?;kotlin.String){}[0] | ||
final inline fun e(kotlin/Throwable? =..., kotlin/String =..., kotlin/Function0<kotlin/String>) // co.touchlab.kermit/Logger.e|e(kotlin.Throwable?;kotlin.String;kotlin.Function0<kotlin.String>){}[0] | ||
final inline fun i(kotlin/String, kotlin/Throwable? =..., kotlin/String =...) // co.touchlab.kermit/Logger.i|i(kotlin.String;kotlin.Throwable?;kotlin.String){}[0] | ||
final inline fun i(kotlin/Throwable? =..., kotlin/String =..., kotlin/Function0<kotlin/String>) // co.touchlab.kermit/Logger.i|i(kotlin.Throwable?;kotlin.String;kotlin.Function0<kotlin.String>){}[0] | ||
final inline fun v(kotlin/String, kotlin/Throwable? =..., kotlin/String =...) // co.touchlab.kermit/Logger.v|v(kotlin.String;kotlin.Throwable?;kotlin.String){}[0] | ||
final inline fun v(kotlin/Throwable? =..., kotlin/String =..., kotlin/Function0<kotlin/String>) // co.touchlab.kermit/Logger.v|v(kotlin.Throwable?;kotlin.String;kotlin.Function0<kotlin.String>){}[0] | ||
final inline fun w(kotlin/String, kotlin/Throwable? =..., kotlin/String =...) // co.touchlab.kermit/Logger.w|w(kotlin.String;kotlin.Throwable?;kotlin.String){}[0] | ||
final inline fun w(kotlin/Throwable? =..., kotlin/String =..., kotlin/Function0<kotlin/String>) // co.touchlab.kermit/Logger.w|w(kotlin.Throwable?;kotlin.String;kotlin.Function0<kotlin.String>){}[0] | ||
|
||
final object Companion : co.touchlab.kermit/Logger { // co.touchlab.kermit/Logger.Companion|null[0] | ||
final val tag // co.touchlab.kermit/Logger.Companion.tag|{}tag[0] | ||
final fun <get-tag>(): kotlin/String // co.touchlab.kermit/Logger.Companion.tag.<get-tag>|<get-tag>(){}[0] | ||
|
||
final fun a(kotlin/String, kotlin/Throwable? =..., kotlin/Function0<kotlin/String>) // co.touchlab.kermit/Logger.Companion.a|a(kotlin.String;kotlin.Throwable?;kotlin.Function0<kotlin.String>){}[0] | ||
final fun addLogWriter(kotlin/Array<out co.touchlab.kermit/LogWriter>...) // co.touchlab.kermit/Logger.Companion.addLogWriter|addLogWriter(kotlin.Array<out|co.touchlab.kermit.LogWriter>...){}[0] | ||
final fun d(kotlin/String, kotlin/Throwable? =..., kotlin/Function0<kotlin/String>) // co.touchlab.kermit/Logger.Companion.d|d(kotlin.String;kotlin.Throwable?;kotlin.Function0<kotlin.String>){}[0] | ||
final fun e(kotlin/String, kotlin/Throwable? =..., kotlin/Function0<kotlin/String>) // co.touchlab.kermit/Logger.Companion.e|e(kotlin.String;kotlin.Throwable?;kotlin.Function0<kotlin.String>){}[0] | ||
final fun i(kotlin/String, kotlin/Throwable? =..., kotlin/Function0<kotlin/String>) // co.touchlab.kermit/Logger.Companion.i|i(kotlin.String;kotlin.Throwable?;kotlin.Function0<kotlin.String>){}[0] | ||
final fun setLogWriters(kotlin.collections/List<co.touchlab.kermit/LogWriter>) // co.touchlab.kermit/Logger.Companion.setLogWriters|setLogWriters(kotlin.collections.List<co.touchlab.kermit.LogWriter>){}[0] | ||
final fun setLogWriters(kotlin/Array<out co.touchlab.kermit/LogWriter>...) // co.touchlab.kermit/Logger.Companion.setLogWriters|setLogWriters(kotlin.Array<out|co.touchlab.kermit.LogWriter>...){}[0] | ||
final fun setMinSeverity(co.touchlab.kermit/Severity) // co.touchlab.kermit/Logger.Companion.setMinSeverity|setMinSeverity(co.touchlab.kermit.Severity){}[0] | ||
final fun setTag(kotlin/String) // co.touchlab.kermit/Logger.Companion.setTag|setTag(kotlin.String){}[0] | ||
final fun v(kotlin/String, kotlin/Throwable? =..., kotlin/Function0<kotlin/String>) // co.touchlab.kermit/Logger.Companion.v|v(kotlin.String;kotlin.Throwable?;kotlin.Function0<kotlin.String>){}[0] | ||
final fun w(kotlin/String, kotlin/Throwable? =..., kotlin/Function0<kotlin/String>) // co.touchlab.kermit/Logger.Companion.w|w(kotlin.String;kotlin.Throwable?;kotlin.Function0<kotlin.String>){}[0] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,4 +38,6 @@ pluginManagement { | |
gradlePluginPortal() | ||
mavenCentral() | ||
} | ||
} | ||
} | ||
|
||
rootProject.name = "kermit-root" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? What is this added for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there is a bug in BCV related to Kotlin/binary-compatibility-validator#261.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops, it still failed on CI, see https://github.com/touchlab/Kermit/actions/runs/11709073063/job/32612290197.
May have to revert this change until the issue has been fixed on BCV side.