Introduce SKIE #310
Merged
Introduce SKIE #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Russell Wolf <[email protected]> Co-authored-by: Jigar Brahmbhatt <[email protected]>
russhwolf
approved these changes
Sep 28, 2023
| @@ -101,7 +103,6 @@ kotlin { | |||
| linkerOpts("-lsqlite3") | |||
| export(libs.touchlab.kermit.simple) | |||
| } | |||
| ios.deploymentTarget = "12.4" | |||
There was a problem hiding this comment.
I recall that something requires you to specify a value here but maybe that changed recently. Does pod install still work if this doesn't put a version in the podspec?
There was a problem hiding this comment.
Pod install does work, I also included some updates to pod/proj stuff in my last commit
| override val isLoading: Boolean = true | ||
| } | ||
|
|
||
| data class Empty @DefaultArgumentInterop.Enabled constructor( |
There was a problem hiding this comment.
SKIE feature request: put this annotation on a class to make it apply to all functions in the class/hierarchy
| @@ -1,18 +1,18 @@ | |||
| [versions] | |||
| kotlin = "1.8.21" | |||
| kotlin = "1.9.0" | |||
There was a problem hiding this comment.
I think 1.9.10 would avoid some potential Xcode 15 issues
There was a problem hiding this comment.
It definitely would, but decided to reduce extra changes as part of this merge
Update the readme, remove some unneeded lines. Update Pods files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces SKIE to KaMPKit. The app is adjusted to make use of SKIE features and remove previous workarounds