Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure new tooling works in docker #6

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

helenb
Copy link
Member

@helenb helenb commented Jan 4, 2024

No ticket

Description of Changes Made

npm run build:prod was failing in Docker as new configuration files weren't being copied over

How to Test

Ensure fab build runs successfully

Screenshots

Expand to see more

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Consider adding unit tests, especially for bug fixes. If you don't, tell us why.
  • Tests and linting passes.
  • Consider updating documentation. If you don't, tell us why.
  • If relevant, list the environments / browsers in which you tested your changes.

@helenb helenb requested a review from engineervix January 4, 2024 10:38
Copy link
Member

@engineervix engineervix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@helenb helenb merged commit 1edfb94 into main Jan 4, 2024
3 checks passed
@helenb helenb deleted the fix/tooling-in-docker branch January 4, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants