Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWE-7 - BE - Division page #324

Open
wants to merge 10 commits into
base: integration/2024-evolution
Choose a base branch
from

Conversation

SharmaineLim
Copy link
Collaborator

@SharmaineLim SharmaineLim commented Dec 19, 2024

Link to Ticket

Description of Changes Made

  • Add the new Division page BE, with the new blocks
    • Dynamic hero block
    • Introduction section block
    • Four photo collage block
Equivalent designs for blocks
Dynamic hero block

image

Introduction section block

image

Four photo collage block

image

Other changes:

  • Move PartnersBlock from services.blocks to core.blocks so we can reuse it.
  • Replace the HomePageFactory and StandardPageFactory unit tests with one unit test that checks that all pages have a factory.

How to Test

  1. Add a child page to the homepage
  2. Create a division page
  3. Populate the fields and save

Screenshots

Editor

image

image

image

image

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@SharmaineLim SharmaineLim marked this pull request as ready for review December 20, 2024 07:55
Comment on lines +69 to +70
factory-boy = "^3.3.0"
faker = "^24.11.0"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added as explicit dependencies since we use them.

@SharmaineLim SharmaineLim requested a review from ababic December 20, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant