Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWE-2 - BE - Add division signpost block #314

Merged

Conversation

SharmaineLim
Copy link
Collaborator

@SharmaineLim SharmaineLim commented Dec 6, 2024

Link to Ticket

Description of Changes Made

This ticket adds a new block for signposting to division pages from the homepage.

FE styling covered by #323

How to Test

  1. Edit the homepage.
  2. Try to add a new block in the Body field. You should see "Division signpost" as a block.
  3. Adding the "Division signpost" block and filling in the required fields should display the new content on the preview.

Screenshots

Editor

image

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

tbx/core/blocks.py Outdated Show resolved Hide resolved
@SharmaineLim SharmaineLim changed the base branch from main to integration/2024-evolution December 9, 2024 08:48
@albinazs albinazs mentioned this pull request Dec 17, 2024
31 tasks
@SharmaineLim SharmaineLim changed the title TWE-2 - BE & FE - Add division signpost block TWE-2 - BE - Add division signpost block Dec 18, 2024
@SharmaineLim SharmaineLim marked this pull request as ready for review December 18, 2024 07:19
@helenb
Copy link
Member

helenb commented Dec 18, 2024

A couple more comments after testing:

I've realised an issue with the design, in that having all the links say 'Find out more' would definitely be an accessibility issue. But as you've allowed the link text to be editable that shouldn't be a problem. It might be helpful to add some help text to make it clear the link text needs to be descriptive.

I noticed that the heading for each card isn't a required field, but it should be.

Finally, should we consider making the minimum number of items 3, as well as the maximum?

@SharmaineLim
Copy link
Collaborator Author

SharmaineLim commented Dec 18, 2024

I noticed that the heading for each card isn't a required field, but it should be.

I didn't make it required because if it's not populated, we can just use the one from the page. (I was planning to do the same for description & image, but then I realised that this project doesn't have listing summaries and listing images.)

I've realised an issue with the design, in that having all the links say 'Find out more' would definitely be an accessibility issue. But as you've allowed the link text to be editable that shouldn't be a problem. It might be helpful to add some help text to make it clear the link text needs to be descriptive.

Finally, should we consider making the minimum number of items 3, as well as the maximum?

Done in 6368e70 and 35503f0

@SharmaineLim SharmaineLim merged commit 8bb2598 into integration/2024-evolution Dec 19, 2024
4 checks passed
@SharmaineLim SharmaineLim deleted the feature/twe-2-division-signpost-block branch December 19, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants