-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TWE-2 - BE - Add division signpost block #314
TWE-2 - BE - Add division signpost block #314
Conversation
A couple more comments after testing: I've realised an issue with the design, in that having all the links say 'Find out more' would definitely be an accessibility issue. But as you've allowed the link text to be editable that shouldn't be a problem. It might be helpful to add some help text to make it clear the link text needs to be descriptive. I noticed that the heading for each card isn't a required field, but it should be. Finally, should we consider making the minimum number of items 3, as well as the maximum? |
I didn't make it required because if it's not populated, we can just use the one from the page. (I was planning to do the same for description & image, but then I realised that this project doesn't have listing summaries and listing images.)
|
Link to Ticket
Description of Changes Made
This ticket adds a new block for signposting to division pages from the homepage.
FE styling covered by #323
How to Test
Screenshots
Editor
MR Checklist
Unit tests
Documentation
Browser testing
Data protection
Light and dark mode
Accessibility
Sustainability
Pattern library