FE | Newsletter sign up #312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add light mode colours * Resolve issue with mix-blend-mode across light and dark themes for the employee owned icon * Update styleguide to switch mode as well as theme * Make the styleguide heading sticky to make it to switch themes when scrolling * Updates to styleguide theme chooser in light mode * Update nebuline-20 colour * Update coral-10 colour * Update lagoon 10 * Update banana 10 * Add 'unripe banana' colour * Update green colour * Nav updates for light mode, and fix footer carbon colour * Add figma colours screenshots to docs * Add dark and light mode for team page map * Always use a dark icon for the instagram gallery
* JS implementation of the site switcher - The cookie is read on the serverside to avoid a FOUC - Based on the RNIB implementation * Update the cookie name to be specific to torchbox * Don't run the mode switcher and set the cookie on page load
* Add light mode colours for defaults and the coral theme - Also resolve issue with mix-blend-mode across light and dark themes for the employee owned icon * Further addition of light mode colours * further fixes and tweaks for light mode * navigation styles don't change between dark and light mode, so use color--white for text * A few more fixes for light mode * Undo change to default mode for testing * Update styleguide to switch mode as well as theme * earth theme will no longer have a buff background colour * Make the styleguide heading sticky to make it to switch themes when scrolling * A few more high contrast mode tweaks * Updates to styleguide theme chooser in light mode * JS implementation of the site switcher - The cookie is read on the serverside to avoid a FOUC - Based on the RNIB implementation * fix to checked attributes and linting * Add back-end functionality to update the mode if javascript is disabled * Added mode switching tests * fix merge conflict marker * Fixes to nav text colours after merge * Update references to 'mode' cookie to be 'torchbox-mode'
* Styling of the site switcher buttons * Further work on site switcher styling - Tweak size of site switcher icons - Re-name a css class - Re-purpose colour--accent-five to be the inverse highlight for the theme * Increase the menu breakpoint to accommodate the site switcher * rename site-switcher to mode-switcher * Add action to form * Update icon colours according to the selected radio button * Styling when js is disabled * Mobile tweaks, duplicate ids, pattern library fix, accessibility fix * High contrast mode tweaks * Update styleguide * Linting * don't cache the mode switcher
- Make the intro rich text - Allow external links in the buttons - Update validation
- Close the mobile menu when focus moves away from the last item at the top level - Improve the functionality for closing the desktop menu when focus moves away from the last item
* Refactor mode switcher to be a toggle, and update colours * Improve aria label on mode toggle
# Conflicts: # tbx/core/context_processors.py # tbx/static_src/sass/config/_variables.scss
|
@albinazs I had a peak at this - I know it is still draft - can you rebase against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Ticket
Description of Changes Made
Todo:
white-space: nowrapfor the Sign up button (issue with the tablet view)How to Test
Screenshots
Expand to see more
MR Checklist
Unit tests
Documentation
Browser testing
Data protection
Light and dark mode
Accessibility
Sustainability
Pattern library