-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add company address to footer #307
Conversation
Hi @ianmeigh, I tested this locally and the layout of the footer now looks quite broken, with the carbon message right over to the right. I can also see there is a pipeline failure (although that looks like it is a temporary blip). Could you look at the layout again, and then I'll do a full review? |
☝️ Fixed in 804ec63. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ianmeigh - code looks good. I think it would be good to get a designer to double check the look and feel though. Thanks!
tbx/project_styleguide/templates/patterns/organisms/footer/footer.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ianmeigh - looks so much better now!
&__company-address { | ||
font-weight: 600; | ||
|
||
> * { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: I'd normally discourage generic child selectors like this, but as it only affects 2 elements I'm not too worried.
Link to Ticket
Description of Changes Made
The footer now includes the company address, including the registered company number and VAT number, as hardcoded values.
How to Test
Test by loading the any page of the website and verifying the information can be seen in the footer element below the logos.
Screenshots
Desktop
Mobile
MR Checklist
Unit tests
Documentation
Browser testing
Data protection
Light and dark mode
Accessibility
Sustainability
Pattern library