Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add company address to footer #307

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Add company address to footer #307

merged 6 commits into from
Oct 9, 2024

Conversation

ianmeigh
Copy link
Collaborator

@ianmeigh ianmeigh commented Oct 7, 2024

Link to Ticket

Description of Changes Made

The footer now includes the company address, including the registered company number and VAT number, as hardcoded values.

How to Test

Test by loading the any page of the website and verifying the information can be seen in the footer element below the logos.

Screenshots

Desktop

image

Mobile

image

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@ianmeigh ianmeigh requested a review from helenb October 7, 2024 16:30
@ianmeigh ianmeigh self-assigned this Oct 7, 2024
@helenb
Copy link
Member

helenb commented Oct 8, 2024

Hi @ianmeigh, I tested this locally and the layout of the footer now looks quite broken, with the carbon message right over to the right. I can also see there is a pipeline failure (although that looks like it is a temporary blip).

Could you look at the layout again, and then I'll do a full review?

Screenshot 2024-10-08 at 09 11 19

@ianmeigh
Copy link
Collaborator Author

ianmeigh commented Oct 8, 2024

☝️ Fixed in 804ec63.

Copy link
Member

@helenb helenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ianmeigh - code looks good. I think it would be good to get a designer to double check the look and feel though. Thanks!

tbx/static_src/sass/components/_footer.scss Outdated Show resolved Hide resolved
@ianmeigh ianmeigh requested a review from helenb October 9, 2024 08:42
Copy link
Member

@helenb helenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ianmeigh - looks so much better now!

&__company-address {
font-weight: 600;

> * {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: I'd normally discourage generic child selectors like this, but as it only affects 2 elements I'm not too worried.

@ianmeigh ianmeigh merged commit 0928ad3 into main Oct 9, 2024
4 checks passed
@ianmeigh ianmeigh deleted the add-footer-address branch October 9, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants