Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with results icon being clipped (featured case study) #273

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

helenb
Copy link
Member

@helenb helenb commented Jul 1, 2024

Link to Ticket

Description of Changes Made

Make the results icon on the featured case-study overflow:visible so the text doesn't get clipped

How to Test

Screenshots

Expand to see more

Before:

Screenshot 2024-07-01 at 14 47 17

After:

Screenshot 2024-07-01 at 14 46 51

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@helenb
Copy link
Member Author

helenb commented Jul 3, 2024

Marking as draft for now as this accidentally includes all the light mode stuff.

@helenb helenb marked this pull request as draft July 3, 2024 07:00
@helenb helenb force-pushed the fix/results-icon-clipping branch from 0b32af6 to 59c66ce Compare July 3, 2024 07:14
@helenb helenb changed the title Fix/results icon clipping Fix issue with results icon being clipped (featured case study) Jul 3, 2024
@helenb helenb requested a review from chris-lawton July 3, 2024 07:16
@helenb helenb marked this pull request as ready for review July 3, 2024 07:16
@helenb
Copy link
Member Author

helenb commented Jul 3, 2024

Marking as draft for now as this accidentally includes all the light mode stuff.

Now sorted out.

@chris-lawton
Copy link
Member

I wonder if the viewbox attr is incorrect as it's odd that the SVG sits in the top left corner and there's a lot of space underneath and to the right of it.

Details

Screenshot 2024-07-03 at 09 27 16

Either that or there's a load of whitespace in the initial SVG.

Anyways this MR fixes it : )

@helenb
Copy link
Member Author

helenb commented Jul 3, 2024

I wonder if the viewbox attr is incorrect as it's odd that the SVG sits in the top left corner and there's a lot of space underneath and to the right of it.

Details
Either that or there's a load of whitespace in the initial SVG.

Anyways this MR fixes it : )

Yes I think the original SVG was a bit off - but going for the quick fix now :)

@helenb helenb merged commit 6282f89 into main Jul 3, 2024
4 checks passed
@helenb helenb deleted the fix/results-icon-clipping branch July 3, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants