Upgrade wagtail to 6.3.2 #1063
Draft
Upgrade wagtail to 6.3.2 #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump django to 4.2.17
This then matches the sites build process docs
Also update the pre-commit hook versions
JakubMastalerz
approved these changes
Jan 9, 2025
Comment on lines
+672
to
+674
| # django-xff (https://github.com/ferrix/xff/?tab=readme-ov-file#configuration) | ||
| # -------------------------------------------------------------------------------------- | ||
| XFF_TRUSTED_PROXY_DEPTH = int(env.get("XFF_TRUSTED_PROXY_DEPTH", 1)) |
There was a problem hiding this comment.
Nitpick: I don't think there's a need to add that section line given that the comment refers to just one setting rather than a whole section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Wagtail to v6.3.2
This pull request includes various updates to dependencies, configurations, and migrations.
Support Ticket
Deploy this: #1062 at the same time to all environments.
Dependency Updates:
.github/workflows/lint.yamland.github/workflows/test.yaml: Updated Poetry version from 1.8.3 to 1.8.5. [1] [2].pre-commit-config.yaml: Updated multiple dependencies includingblack,flake8,django-upgrade, andpyupgradeto their latest versions. [1] [2] [3]Dockerfile: Updated Poetry version from 1.8.3 to 1.8.5.pyproject.toml: Upgraded various dependencies such aswagtail,django-basic-auth-ip-whitelist,django-cors-headers,dj-database-url,coverage,sentry-sdk, and more.Migrations:
rca/documents/migrations/0005_wagtail_63_upgrade.py: Added a migration to update thefile_sizefield in theCustomDocumentmodel to usePositiveBigIntegerField.rca/images/migrations/0008_wagtail_63_upgrade.py: Added a migration to include adescriptionfield in theCustomImagemodel.Configuration Changes:
rca/settings/base.py: AddedXForwardedForMiddlewareand configureddjango-xffsettings for trusted proxy depth. [1] [2] [3]Wagtail 6.3 (LTS) release notes
Add a link to the commit or file for each consideration if you made any code changes.
Code reviewing a consideration.
Use the tick box to indicate a consideration has been code reviewed as OK.
Upgrade considerations - deprecation of old functionality
Upgrade considerations - changes to undocumented internals