Rename controller package to metrics #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daichimukai
previously approved these changes
Aug 2, 2023
We have similar packages such as controller and controllers, which makes us confusing. controller package is used by controller sub command, therefore the name is as. But, it is actually related to metrics, so I change its name to metrics. Also, runners package has too few logic, I embed it into cmd/controller.go directly. Signed-off-by: Toshikuni Fukaya <[email protected]>
daichimukai
approved these changes
Aug 8, 2023
llamerada-jp
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have similar packages such as controller and controllers, which makes us confusing. controller package is used by controller sub command, therefore the name is as. But, it is actually related to metrics, so I change its name to metrics. Also, runners package has too few logic, I embed it into cmd/controller.go directly.