support .spec.pvcCapacity in PieProbe CR #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushitora-anqou
force-pushed
the
support-to-change-pvc-capacity
branch
from
22b267d
to
03518ec
Compare
Some filesystems (like xfs and btrfs) only support volumes over certain amounts of capacities. Currently, pie uses 100 MiB volumes in any case, so it won't work on such filesystems. This commit solves this problem by adding .spec.pvcCapacity field to PieProbe custom resource. When the user set some value to .spec.pvcCapacity, pie will use the value as the PVC's capacity. The default value of this field is 100 MiB, so pie should behave in the same way as before if the user doesn't specify the field. Signed-off-by: Ryotaro Banno <[email protected]>
Signed-off-by: Ryotaro Banno <[email protected]>
ushitora-anqou
force-pushed
the
support-to-change-pvc-capacity
branch
from
03518ec
to
fdba009
Compare
peng225
reviewed
Aug 6, 2024
Could you clarify a bit more? Are you referring to the tests located in the test/e2e directory? If that's the case, the tests in test/e2e/suite_test.go only verify that the pie's metrics are functioning correctly, and there are already some tests for both of provision and mount probes. |
llamerada-jp
approved these changes
Aug 7, 2024
Yes, but I noticed my misunderstanding about the current tests. |
peng225
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some filesystems (like xfs and btrfs) only support volumes over certain amounts of capacities. Currently, pie uses 100 MiB volumes in any case, so it won't work on such filesystems.
This commit solves this problem by adding .spec.pvcCapacity field to PieProbe custom resource. When the user set some value to .spec.pvcCapacity, pie will use the value as the PVC's capacity. The default value of this field is 100 MiB, so pie should behave in the same way as before if the user doesn't specify the field.