Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage capacity scoring KEP #1

Closed
wants to merge 46 commits into from

Conversation

bells17
Copy link

@bells17 bells17 commented Aug 10, 2022

No description provided.

@peng225
Copy link

peng225 commented Aug 31, 2022

@bells17
updateして頂いたdesign detailの章について、流れとしては気になるところはありませんでした。軽微な指摘を入れさせて頂いたので、ご対応頂ければと思います。

@cupnes cupnes requested a review from toshipp March 20, 2023 08:23
@cupnes cupnes marked this pull request as ready for review March 20, 2023 08:24

On the following cases, it is needed to schedule pods considering storage capacity.

- We want to select a node with as much free space as possible so that we can resize after a node-local PV is scheduled, and use storage as evenly as possible among the nodes.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use storage as evenly as possible among the nodes

このケースがなぜ必要かがわからないので消したほうが良いかも。

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

どちらかというと resize したいから、フリースペースがあるノードを選びたいので、
Because we want to resize ..., it should select a node ... とかのほうが良いかも

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

77cd66b で修正済み

Comment on lines 393 to 394
The PR below is a PoC implementation of the above design.
https://github.com/bells17/kubernetes/pull/1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KEPから外部リポジトリ参照するのは微妙なんで消したほうが良い気がします。

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

77cd66b で修正済み

cupnes and others added 17 commits March 22, 2023 16:51
@cupnes cupnes requested a review from toshipp March 27, 2023 08:52
@cupnes cupnes requested a review from toshipp March 28, 2023 00:11
@cupnes
Copy link

cupnes commented May 18, 2023

This PR has been reworked into the following PR.
#2

@cupnes cupnes closed this May 18, 2023
@cupnes cupnes deleted the storage-capacity-scoring-kep branch May 18, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants