Skip to content

Commit

Permalink
test if gh-pages works without public-url option
Browse files Browse the repository at this point in the history
  • Loading branch information
tomtuamnuq committed Mar 15, 2024
1 parent 283b70b commit a393593
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ jobs:
# this is necessary for github pages where the site is deployed to username.github.io/repo_name and all files must be requested
# relatively as eframe_template/favicon.ico. if we skip public-url option, the href paths will instead request username.github.io/favicon.ico which
# will obviously return error 404 not found.
run: ./trunk build --release --public-url "${GITHUB_REPOSITORY#*/}"
# causes problems with the path resolution see https://github.com/emilk/eframe_template/issues/116
# run: ./trunk build --release --public-url "${GITHUB_REPOSITORY#*/}"
run: ./trunk build --release
- name: Deploy
uses: JamesIves/github-pages-deploy-action@v4
with:
Expand Down

0 comments on commit a393593

Please sign in to comment.