Add missing icon sizes

[leoheitmannruiz]

If Firefox doesn't encounter the icon size it expects, it fetches the icon from addons.mozilla.org.

This is especially annoying on a slow connection or when not connected at all. But generally, I'd just rather have it not download the icon.

This should add all sizes.

magick icon128.png -resize 16x16 icon16.png
magick icon128.png -resize 32x32 icon32.png
magick icon128.png -resize 64x64 icon64.png
magick icon128.png -resize 96x96 icon96.png

zopflipng -y icon16.png icon16.png
zopflipng -y icon32.png icon32.png
zopflipng -y icon64.png icon64.png
zopflipng -y icon96.png icon96.png

[tom-james-watson]

Hi!

Firefox is using manifest-v2, so that would need updating too. Manifest-v3 is Chrome-only at the moment.

Where are you getting this list of sizes from? When are these images used and when are you seeing a slow down because of that?

[leoheitmannruiz]

Yeah, so, hehe

I think I've made this a lot more complicated than it should have, sorry.

The icon situation is Firefox specific, which is why I first added the icons to manifest-v2.

But then I sent my other PR, and thought you'd use the V3 version for both Chrome and Firefox, so I updated this PR and force-pushed. I suppose that was a little silly :)

Also, I edited my description. The original description was a lot better. Silly me again.

A fresh start:

If Firefox doesn't encounter the icon size it wants, it fetches the icon from https://addons.mozilla.org/user-media/addon_icons/*

On my 2022 MacBook Air, this happens at about:addons (at most zoom levels, including 100%) and in the extension pop up thingie (the puzzle piece).

Normally, if Firefox doesn't encounter the icon size it wants, it downloads it once and then it's got it. However, I clear my browsers cache regularly (that is, when closing my browser). As a result, often when I visit about:addons or click the puzzle piece, the icon is fetched again.

On a slow connection this is very notable, as the other icons are displayed instantly, while the Old Reddit Redirect icon takes a moment. And when I'm not connected at all, there's no icon.

Where are you getting this list of sizes from?

Mostly by testing all zoom levels, while not connected, and checking what URL Firefox wants to get the icon from (by clicking "open in new tab" where there should have been an icon):

And, checking what other extensions do:

• https://github.com/gorhill/uBlock/blob/master/platform/firefox/manifest.json#L98-L103
• https://github.com/keepassxreboot/keepassxc-browser/blob/develop/dist/manifest_firefox.json#L8-L13

The whole extension icon situation at Firefox sadly seems a little weird.

Something I had in my original description:

I can imagine this being an annoying PR, especially as it ads ~10KB to a ~20KB add-on. Hope it's fine ^^

Alternatively, a single SVG file can be used for all sizes (though, only for Firefox). Do you perhaps have one?

If you want to, I can try and recreate the icon as an SVG, though, of course, it's going to differ ever so slightly.

[leoheitmannruiz]

I changed the commit back to adding the icons to manifest-v2.

[tom-james-watson]

Ahh ok, thanks for the explanation! I will leave this for later and merge this and do the switch for manifest-v3 only. I want to let the other version publish and go out first, plus I have some holidays coming up, so will probably not be for a few weeks.

[leoheitmannruiz]

Cool! Enjoy your holiday!!

[leoheitmannruiz]

How's it looking with this and the manifest v3?