added feature for extra delay for grpc apis #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ardiannn08
previously approved these changes
Apr 13, 2021
Ardiannn08
reviewed
Apr 14, 2021
|
Can we merge this pr? Ardiannn08 approved it. |
jekiapp
requested changes
May 6, 2021
| @@ -60,6 +59,7 @@ type Input struct { | |||
| } | |||
|
|
|||
| type Output struct { | |||
| Delay Duration `json:"delay"` | |||
There was a problem hiding this comment.
I think we can't do it directly under Output struct, can you please create a Meta field and put duration under it?
There was a problem hiding this comment.
Hey @jekiapp Duration is meta field defined in file stub/duration.go, such that
type Duration struct {
time.Duration
}
There was a problem hiding this comment.
@shubhjha123 I mean like this
type Output struct{
Meta Meta
}
type Meta struct{
Delay Duration
}
|
Hi, sorry for the delayed review 🙏 I just saw it today. if you're nakama you can reach me by @jeki in slack. |
|
@jekiapp @shubhjha123 @Ardiannn08 is somebody looking to merge this? This seems to be a need now. |
|
What is the status on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our use of gripmock we came across a need of extra delay over grpc response. Added code for extraa delay for grpc apis, which can help library users to configure any delay in their api response.