added output parameter to keep server stream open #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveen1100
commented
Apr 8, 2021
naveen1100
commented
- This PR provides an option to keep sending the same data from the server to the client without disconnecting the stream. This is used to mock long-running server streams
- In addition it contains changes in Dockefile since the existing Dockerfile doesn't seem to work
stream open
jekiapp
reviewed
May 6, 2021
| @@ -1,18 +1,23 @@ | |||
| FROM golang:alpine | |||
|
|
|||
| FROM golang:1.15.3 | |||
There was a problem hiding this comment.
what requires this PR to use this golang version?
jekiapp
reviewed
May 6, 2021
| if !KeepServerStreamOpen { | ||
| return nil | ||
| } | ||
| time.Sleep(25 * time.Second) |
jekiapp
requested changes
May 6, 2021
| Error string `json:"error"` | ||
| Data interface{} `json:"data"` | ||
| Error string `json:"error"` | ||
| KeepServerStreamOpen bool `json:"keepServerStreamOpen"` |
There was a problem hiding this comment.
I think we need to put it under Meta field, and instead of boolean, it should receive duration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.