-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proto uploads and multi projects proto #54
base: master
Are you sure you want to change the base?
Conversation
haha thankyou for creating this PR, it must be a lot of hardwork. But first, instead of focusing on the chages I am more interested about the motivation for each changes. Like uploading the proto is interesting, but what challenge you face until you made that feature? Actually one of the issue gripmock has is generated code is placed in the top level. I forgot which issue it is but it's there. |
The multi-project support from this MR would actually come super useful. @jekiapp any change an MR with just that change would be accepted? |
Hi @jekiapp, can you merge the feature allowing for proto upload? |
kudos to @quintans ! I see some pretty useful changes in the PR, but this PR is definitely too huge to merge ... cherry picking from this work is also non-trivial, from current commits ... Probably need to separate the several features into PRs respectively in order to get things moving @jekiapp WDYT |
Hi guys, sorry for the late replies. |
This is a massive change. I just went crazy 😄
I understand if this gets rejected. Feel free to cherry pick any change.
changes:
*.pg.go
into GOPATH