sync: handle panic during mpsc drop #7094
Merged
+72
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
mpsc
to handle panics during thedrop
. Specifically, thechan::Rx
will continue executing itsdrop
even if a panic occurs during thedrop
.Although this scenario is expected to be rare, there could be edge cases, for example:
chan::Rx
is droppedchan::Chan
is dropped (resuming from the interrupted element)chan::Chan
This PR prevents such cases by enforcing a double panic on thread1.