Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanban mobile drag PoC #9048

Closed
wants to merge 10 commits into from
Closed

Conversation

alsuren
Copy link

@alsuren alsuren commented Dec 27, 2024

This PR includes:

  • A fix for when the drag and drop can get into a bad state after the browser sends us a pointercancel event
  • An implementation of drag and drop for mobile
    • kanban/mobile/controller/drag.ts is mostly copy-paste from kanban/pc/controller/drag.ts . Do you want me to DRY it out at all?
    • I have disabled the "mobile databases are readonly" logic from d90ff22 until someone can give me a bit more context (I have asked in #technical-discussion on discord). If you have a suggested fix for this, please leave a comment (or just push your proposed fix to my branch).
  • A playwright test that exercises drag and drop on mobile and pc.

This is based on top of #9044 so it included a basic playwright test. I'm happy to merge this as two separate PRs or close the other one if you prefer.

@alsuren alsuren requested a review from a team as a code owner December 27, 2024 18:45
Copy link

changeset-bot bot commented Dec 27, 2024

⚠️ No Changeset found

Latest commit: 4eab55b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 6:46pm

Copy link

vercel bot commented Dec 27, 2024

@alsuren is attempting to deploy a commit to the toeverything Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

graphite-app bot commented Dec 27, 2024

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

nx-cloud bot commented Dec 27, 2024

View your CI Pipeline Execution ↗ for commit 4eab55b.

Command Status Duration Result
nx vite:build @blocksuite/playground ✅ Succeeded 32s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-27 18:46:43 UTC

@Saul-Mirone
Copy link
Collaborator

Hi, thanks for your contribution. However, reagarding #9045, we don't accept new pr in this repo. If you still want to contribute, you can move your pr to https://github.com/toeverything/AFFiNE.
You can find most of the code in blocksuite folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants