Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blocks): add event tracking for attachment upload #9008

Merged

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Dec 18, 2024

Part of: AF-1678

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 3:05pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 3:05pm

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: b969801

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

fundon commented Dec 18, 2024


How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Dec 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b969801. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@fundon fundon marked this pull request as ready for review December 18, 2024 10:35
@fundon fundon requested a review from a team as a code owner December 18, 2024 10:35
@fundon fundon force-pushed the fundon/12_18_add_event_tracking_for_attachment_upload branch from dea2890 to ee613b7 Compare December 18, 2024 10:43
Copy link

graphite-app bot commented Dec 18, 2024

Merge activity

  • Dec 18, 8:43 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 18, 8:50 AM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Dec 18, 9:31 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Dec 18, 10:03 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 18, 10:09 AM EST: A user merged this pull request with the Graphite merge queue.

@fundon fundon changed the base branch from fundon/12_18_reuse_attachment_upload_method to graphite-base/9008 December 18, 2024 13:50
@fundon fundon force-pushed the fundon/12_18_add_event_tracking_for_attachment_upload branch from 542c873 to bd523c2 Compare December 18, 2024 14:58
@fundon fundon force-pushed the graphite-base/9008 branch from 9f443bc to 789a172 Compare December 18, 2024 14:58
@fundon fundon changed the base branch from graphite-base/9008 to master December 18, 2024 14:58
Copy link
Contributor

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.11 MB (+0.05% 🔺)
@blocksuite/affine/block-std 158.79 KB (0%)
@blocksuite/affine/block-std/gfx 82.73 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.9 KB (0%)
@blocksuite/affine/global/env 217 B (0%)
@blocksuite/affine/global/exceptions 562 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.66 KB (0%)
@blocksuite/affine/inline 32.66 KB (0%)
@blocksuite/affine/inline/consts 242 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.9 MB (+0.02% 🔺)
@blocksuite/affine/blocks 2 MB (+0.02% 🔺)
@blocksuite/affine/blocks/schemas 88.96 KB (0%)

@graphite-app graphite-app bot merged commit b969801 into master Dec 18, 2024
36 checks passed
@graphite-app graphite-app bot deleted the fundon/12_18_add_event_tracking_for_attachment_upload branch December 18, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants