Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edgeless): rewrite mind map drag indicator #8805

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

doouding
Copy link
Member

@doouding doouding commented Nov 26, 2024

Changed

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 8:04am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 8:04am

Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: baf69b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Nov 26, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

doouding commented Nov 26, 2024


How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Nov 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit baf69b2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

github-actions bot commented Nov 26, 2024

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.1 MB (-0.04% 🔽)
@blocksuite/affine/block-std 156.89 KB (-0.11% 🔽)
@blocksuite/affine/block-std/gfx 80.69 KB (-0.04% 🔽)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.88 KB (-0.05% 🔽)
@blocksuite/affine/global/env 217 B (0%)
@blocksuite/affine/global/exceptions 562 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.26 KB (0%)
@blocksuite/affine/inline 32.09 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.9 MB (+0.13% 🔺)
@blocksuite/affine/blocks 1.99 MB (+0.06% 🔺)
@blocksuite/affine/blocks/schemas 88.7 KB (-0.26% 🔽)

@doouding doouding force-pushed the 11-26-fix_expand_mind_map_area branch from 8537482 to c5a8d0f Compare December 2, 2024 07:00
@doouding doouding changed the title fix: expand mind map area feat: rewrite overlay Dec 2, 2024
@doouding doouding changed the title feat: rewrite overlay feat: visual change on mind map drag indicator Dec 2, 2024
@doouding doouding force-pushed the 11-26-fix_expand_mind_map_area branch from ea361ac to 8cf2b40 Compare December 5, 2024 10:09
@doouding doouding force-pushed the 11-26-fix_expand_mind_map_area branch from 8cf2b40 to 1feb37d Compare December 9, 2024 09:53
@doouding doouding force-pushed the 11-26-fix_expand_mind_map_area branch from 1feb37d to 286432a Compare December 10, 2024 02:31
@doouding doouding changed the title feat: visual change on mind map drag indicator feat: map drag indicator Dec 12, 2024
@doouding doouding marked this pull request as ready for review December 12, 2024 07:08
@doouding doouding requested a review from a team as a code owner December 12, 2024 07:08
@doouding doouding changed the title feat: map drag indicator feat: rewrite mind map drag indicator Dec 12, 2024
@doodlewind doodlewind changed the title feat: rewrite mind map drag indicator feat(edgeless): rewrite mind map drag indicator Dec 12, 2024
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Dec 12, 2024

Merge activity

### Changed
- Rewrite visual design of mind map drag indicator
- Drag issues fixed in #8837
@doouding doouding force-pushed the 11-26-fix_expand_mind_map_area branch from 286432a to baf69b2 Compare December 12, 2024 08:02
@graphite-app graphite-app bot merged commit baf69b2 into master Dec 12, 2024
36 checks passed
@graphite-app graphite-app bot deleted the 11-26-fix_expand_mind_map_area branch December 12, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants