feat(electron): move @blocksuite/affine to peer dependences for package speed on windows #9756
+21
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
mod:env
app:electron
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #9756 +/- ##
=======================================
Coverage 53.25% 53.25%
=======================================
Files 2194 2194
Lines 98789 98789
Branches 16745 16745
=======================================
Hits 52612 52612
Misses 44769 44769
Partials 1408 1408
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pengx17
force-pushed
the
01-17-feat_electron_move_blocksuite_affine_to_peer_dependences_for_package_speed_on_windows
branch
2 times, most recently
from
d76f563 to
ead7559
Compare
forehalo
approved these changes
Jan 18, 2025
Merge activity
|
…ge speed on windows (#9756) `@blocksuite/affine` is indirectly depended by electron package. It has around 120k files in total and will greatly slow down forge package build speed. Move them to peer dependencies to mitigate the issue.
forehalo
force-pushed
the
01-17-feat_electron_move_blocksuite_affine_to_peer_dependences_for_package_speed_on_windows
branch
from
ead7559 to
f689c2f
Compare
graphite-app
bot
deleted the
01-17-feat_electron_move_blocksuite_affine_to_peer_dependences_for_package_speed_on_windows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@blocksuite/affineis indirectly depended by electron package. It has around 120k files in total and will greatly slow down forge package build speed.Move them to peer dependencies to mitigate the issue.