Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): improve doc title and icon display #9755

Merged

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Jan 17, 2025

Closes: AF-2132

Copy link
Contributor Author

fundon commented Jan 17, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fundon fundon force-pushed the fundon/01_17_improve_doc_title_and_icon_display branch from aea4d6e to 7f7ada7 Compare January 17, 2025 08:00
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.25%. Comparing base (d048ac6) to head (7436c13).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff            @@
##           canary    #9755    +/-   ##
========================================
  Coverage   53.25%   53.25%            
========================================
  Files        2194     2194            
  Lines       98790    98789     -1     
  Branches    16746    16745     -1     
========================================
  Hits        52612    52612            
- Misses      44267    44769   +502     
+ Partials     1911     1408   -503     
Flag Coverage Δ
server-test 78.52% <ø> (ø)
unittest 32.07% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/01_17_improve_doc_title_and_icon_display branch 2 times, most recently from fb8540d to ec275ac Compare January 17, 2025 09:44
@fundon fundon marked this pull request as ready for review January 17, 2025 09:46
@fundon fundon requested a review from a team as a code owner January 17, 2025 09:46
@graphite-app graphite-app bot requested review from a team January 17, 2025 09:46
@fundon fundon force-pushed the fundon/01_17_improve_doc_title_and_icon_display branch from ec275ac to 1f9dba2 Compare January 17, 2025 10:27
@github-actions github-actions bot added the test Related to test cases label Jan 17, 2025
@fundon fundon force-pushed the fundon/01_17_improve_doc_title_and_icon_display branch from 1f9dba2 to 08ff437 Compare January 17, 2025 10:28
Copy link
Contributor

@L-Sun L-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fundon fundon force-pushed the fundon/01_17_improve_doc_title_and_icon_display branch from 08ff437 to 3c34306 Compare January 17, 2025 10:37
Copy link

graphite-app bot commented Jan 17, 2025

Merge activity

  • Jan 17, 6:27 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 17, 6:51 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Desktop Test (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)').
  • Jan 18, 3:54 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 18, 4:11 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Desktop Test (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)').
  • Jan 18, 4:46 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 18, 4:47 AM EST: A user merged this pull request with the Graphite merge queue.

@fundon fundon force-pushed the fundon/01_17_improve_doc_title_and_icon_display branch from fe74533 to 7436c13 Compare January 18, 2025 09:29
@graphite-app graphite-app bot merged commit 7436c13 into canary Jan 18, 2025
61 checks passed
@graphite-app graphite-app bot deleted the fundon/01_17_improve_doc_title_and_icon_display branch January 18, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants