Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added status messages for listaddons and file test #403

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chrysle
Copy link
Contributor

@chrysle chrysle commented Jan 21, 2023

Before submitting a pull request, please make sure the following is done:

  • Fork the repository and create your branch from master.
  • If you've added code that should be tested, add tests!
  • Ensure the test suite passes.
  • Format your code with ShellCheck.
  • Include a human-readable description of what the pull request is trying to accomplish.
  • Steps for the reviewer(s) on how they can manually QA the changes.
  • Have a fixes #XX reference to the issue that this pull request fixes.

I have enlarged the repertoire of status messages again, this time for listaddons. I also added a file test operator for the _list function, which would otherwise break if a non-existing file with absolute path was given.

todo.sh Outdated Show resolved Hide resolved
todo.sh Outdated Show resolved Hide resolved
todo.sh Outdated Show resolved Hide resolved
todo.sh Outdated Show resolved Hide resolved
@chrysle chrysle requested a review from inkarkat January 22, 2023 16:40
Copy link
Member

@inkarkat inkarkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; depends on #404 to be merged first for all tests to succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants