-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added warning message for todo.sh archive #399
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea; it's nice to give precise messages about what has been done (or not); especially when doing so does not require extra work - the grep
command already tells us whether there are done tasks. However:
After your change, archiving becomes non-functional if TODOTXT_VERBOSE=0
; line 1145 just echos the done tasks if verbose is on; I think you need to use the following line's grep
to check for done tasks. The tests (make test
) are also failing - please add a test for your warning message to tests/t1900-archive.sh
.
544c006
to
b9709c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding tests! (The test failures can be ignored; there's a problem with MacOS platforms and apparently now also with Ubuntu 18.04.) I think we're almost there now.
Should I squash my commits? |
You can squash if you want to, but there's no need. The change is looking fine now, thanks a lot! It'll probably still take some time (at least until January) until this gets merged, we currently have a bit of a backlog of PRs, but @karbassi has a New Year's resolution of devoting some time to this project, and we'll very likely also do a fresh release then ;-) |
I have added a warning message which
todo.sh archive
will print out if it does not find done tasks in the todo file.Before, it would even then print
TODO: ./todo.txt archived
.Before submitting a pull request, please make sure the following is done:
master
.fixes #XX
reference to the issue that this pull request fixes.