Skip to content

Commit

Permalink
Tidy up before 2.2.0 release
Browse files Browse the repository at this point in the history
  • Loading branch information
tneotia committed Jun 14, 2021
1 parent 81bf4a5 commit a385c89
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ their current selection (e.g. tap on a different word, create a new node, select
* Fixed minor bug with automatic height adjustment on mobile
* Added new `ToolbarType.nativeExpandable` which allows the user to switch between the
scrollview or gridview toolbar on the fly
* Support setting the `inputmode` for the editor, which changes the virtual keyboard display on mobile devices (e.g. number pad, email keyboard, etc)
* [BREAKING] renamed `onChange` callback to `onChangeContent`
* [BREAKING] disabled a lot of the buttons by default, now only around half of the editor buttons
are enabled to improve the UX. You can still re-enable the rest if you want.
Expand Down
4 changes: 3 additions & 1 deletion lib/src/widgets/html_editor_widget_mobile.dart
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,9 @@ class _HtmlEditorWidgetMobileState extends State<HtmlEditorWidget> {
await controller.evaluateJavascript(
source:
"document.onselectionchange = onSelectionChange; console.log('done');");
await controller.evaluateJavascript(source: "document.getElementsByClassName('note-editable')[0].setAttribute('inputmode', '${describeEnum(widget.htmlEditorOptions.inputType)}');");
await controller.evaluateJavascript(
source:
"document.getElementsByClassName('note-editable')[0].setAttribute('inputmode', '${describeEnum(widget.htmlEditorOptions.inputType)}');");
if ((Theme.of(context).brightness == Brightness.dark ||
widget.htmlEditorOptions.darkMode == true) &&
widget.htmlEditorOptions.darkMode != false) {
Expand Down
3 changes: 1 addition & 2 deletions lib/utils/utils.dart
Original file line number Diff line number Diff line change
Expand Up @@ -390,8 +390,7 @@ class _DropdownMenuState<T> extends State<_DropdownMenu<T>> {
type: MaterialType.transparency,
textStyle: route.style,
child: ScrollConfiguration(
behavior: ScrollConfiguration.of(
context).copyWith(
behavior: ScrollConfiguration.of(context).copyWith(
overscroll: false,
physics: const ClampingScrollPhysics(),
platform: Theme.of(context).platform,
Expand Down

0 comments on commit a385c89

Please sign in to comment.