Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: sgx ci/cd #631

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from
Open

ci: sgx ci/cd #631

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e166fef
ci for sgx
maceip Oct 9, 2024
2e5dc2f
+ cd
maceip Oct 9, 2024
15e45e8
fix: bash var assign
maceip Oct 9, 2024
088bb44
Update Caddyfile
maceip Oct 9, 2024
c9a90dc
Update tee-ci.yml
maceip Oct 9, 2024
06b60bf
Update tee-cd.yml
maceip Oct 9, 2024
eb8d7e7
Create gramine.sh
maceip Oct 9, 2024
863f183
Update gramine.sh
maceip Oct 9, 2024
a1da7a4
Update tee-cd.yml
maceip Oct 9, 2024
90c495b
Update updateproxy.sh
maceip Oct 15, 2024
ce8dcce
Update ci.yml
maceip Oct 21, 2024
30d19e1
fix cd interop
maceip Nov 6, 2024
cb0acd3
fi cd script folder structure
maceip Nov 6, 2024
3ac8998
smoke tested
maceip Nov 9, 2024
3862bfc
Update tee-cd.yml
maceip Nov 9, 2024
539aefe
Update gramine.sh
maceip Nov 9, 2024
7ae1b94
Update updateproxy.sh
maceip Nov 9, 2024
3f0b93a
Update tee-cd.yml
maceip Nov 9, 2024
ad83fd0
Update tee-cd.yml
maceip Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,4 +138,11 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: lcov.info
fail_ci_if_error: true
fail_ci_if_error: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
trigger-deployment:
trigger-tee-deployment:

Copy link
Member

@yuroitaki yuroitaki Oct 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't this deployment run everytime a PR is raised? as the trigger condition in this ci.yml is

on:
  push:
    branches:
      - dev
    tags:
      - "[v]?[0-9]+.[0-9]+.[0-9]+*"
  pull_request:
     ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add this to the trigger-tee-deployment job:

    # only for dev branch and tags
    if: github.event_name == 'push' && (startsWith(github.ref, 'refs/tags/') || github.ref == 'refs/heads/dev')

trigger-deployment:
# doing this here due to feedback @ https://github.com/tlsnotary/tlsn/pull/631#issuecomment-2415806267
needs: tests-integration
uses: ./.github/workflows/tee-cd.yml
with:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# what this is supposed to do -> $ref is the tag: e.g., v0.1.0-alpha.7; pass the $ref string to the cd script and update reverse proxy / deploy
# pass the $ref string to the cd script and update reverse proxy / deploy
# $ref is the tag: e.g., v0.1.0-alpha.7

# what this is supposed to do -> $ref is the tag: e.g., v0.1.0-alpha.7; pass the $ref string to the cd script and update reverse proxy / deploy
ref: ${{ github.ref_name }}
Loading