Add ci build for WASM target for specific packages #394
Conversation
heeckhau
changed the title
heeckhau
force-pushed
the
297-add-wasm-build-to-ci
branch
from
b2ab546
to
450f8b8
Compare
heeckhau
changed the title
| @@ -45,3 +45,6 @@ bincode.workspace = true | |||
| [[test]] | |||
| name = "api" | |||
| required-features = ["fixtures"] | |||
|
|
|||
| [target.'cfg(target_arch = "wasm32")'.dependencies] | |||
There was a problem hiding this comment.
Should ring = { version = "0.17", features = ["wasm32_unknown_unknown_js"] } also be required here since tlsn-tls-core is a dependency and it depends on ring?
There was a problem hiding this comment.
@mhchia I am not sure. I have not fully analysed the dependencies.
It builds without specifying it here, so that is why I didn't add it here.
There was a problem hiding this comment.
I think tls-core already pulls in ring 0.17 because it has ring.workspace = true. So no need to make it a dependency of tlsn-core?
There was a problem hiding this comment.
Ahh, haven't thought about this. Following this additive-features it would probably work in most cases, since it is never pulled in alone.
But it would probably be better to add the feature to tls-core then?
There was a problem hiding this comment.
Following this additive-features it would probably work in most cases, since it is never pulled in alone.
I see. Thanks for sharing! If tlsn-core is not used alone then whether adding or not both works for me 🙏
No description provided.