Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove close_notify guard #336

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: remove close_notify guard #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions tlsn/tlsn-prover/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,17 +173,6 @@ impl Prover<Setup> {
_ = mux_fut => return Err(std::io::Error::from(std::io::ErrorKind::UnexpectedEof))?,
};

// Extra guard to guarantee that the server sent a close_notify.
//
// DO NOT REMOVE!
//
// This is necessary, as our protocol reveals the MAC key to the Notary afterwards
// which could be used to authenticate modified TLS records if the Notary is
// in the middle of the connection.
if !client.received_close_notify() {
return Err(ProverError::ServerNoCloseNotify);
}

let backend = client
.backend_mut()
.as_any_mut()
Expand Down