Finish removing Ring dependency #295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themighty1
approved these changes
Aug 8, 2023
| @@ -1,6 +1,37 @@ | |||
| // Additional x509/asn1 functions to those provided in webpki/ring. | |||
|
|
|||
| use ring::io::der; | |||
| pub const CONSTRUCTED: u8 = 1 << 5; | |||
| pub const CONTEXT_SPECIFIC: u8 = 2 << 6; | |||
Closed
# Conflicts: # components/tls/tls-core/Cargo.toml
|
This is no longer necessary, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes removing
ringfromtls-coreandtls-clientto support wasm builds. This was relatively straight forward as we only support P256 at the moment. I've verified locally that thetls-clientcrate now builds forwasm32-unknown-unknown. We will want to add this to our CI.Changes
ringwith functional equivalents from RustCrypto (key exchange, signing and hashing).ringconstant time slice comparison withsubtleEdd25519andRsasigning impls