Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to upload datapackages when not using SSL #94

Closed
wants to merge 3 commits into from

Conversation

lucasburlingham
Copy link

This PR seeks to fix #92 where users cannot upload datapackages when the server is configured to use the TCP streaming protocol.

Confirmed working while running taky_deps on the command line and when installed as a systemctl service. I have not tested it with SSL on, as generating SSL certs are broken on Ubuntu >22.04.

Thank you @tkuester.

@tkuester
Copy link
Owner

tkuester commented Apr 5, 2024

Hey @lucasburlingham ! Thanks for the pull request!

I had a small pedantic change, I ended up using Flask's app.config to check instead of passing around the app_config object. That's a rather ugly part of the code I plan to get rid of later. While I didn't pull your commit in directly, I'll make sure to credit you in the changelog!

@tkuester tkuester closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

401 errors from taky_dps
2 participants