EWK Minor Changes #469
EWK Minor Changes #469
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| @@ -6,6 +6,7 @@ type OauthRequest = { | |||
| suborgID: string; | |||
| oidcToken: string; | |||
| targetPublicKey: string; | |||
| sessionLength?: number | undefined; | |||
There was a problem hiding this comment.
Nit: we should specify either in name or comment that this is expressed in seconds
Another thing is around type: we're going to cast to string anyways so we could just expect a string all the way through, but at the same time number is probably more intuitive
There was a problem hiding this comment.
yep agreed! I'm indifferent on number vs string
.changeset/lemon-spoons-own.md
Outdated
| "@turnkey/sdk-react": patch | ||
| --- | ||
|
|
||
| Add session length customization, more css customization and fixes |
There was a problem hiding this comment.
Can you detail the fixes here?
moe-dev
force-pushed
the
moe/minor-ewk-updates-jan6
branch
2 times, most recently
from
d43774c to
02326c5
Compare
moe-dev
force-pushed
the
moe/minor-ewk-updates-jan6
branch
from
02326c5 to
b90947e
Compare
| @@ -7,7 +7,7 @@ type OtpAuthRequest = { | |||
| otpId: string; | |||
| otpCode: string; | |||
| targetPublicKey: string; | |||
| sessionLength?: number | undefined; | |||
| sessionLength?: number | undefined; // Desired expiration time in seconds for the generated API key | |||
There was a problem hiding this comment.
Ah I meant we could add seconds to the param name like sessionLengthSeconds (similar to expirationSeconds). A little verbose, but might be easier for developers when their editor populates params (they might not see the actual code/comment, but should see what params are available).
| @@ -6,6 +6,7 @@ type OauthRequest = { | |||
| suborgID: string; | |||
| oidcToken: string; | |||
| targetPublicKey: string; | |||
| sessionLengthSeconds?: number | undefined; // Desired expiration time in seconds for the generated API key | |||
There was a problem hiding this comment.
generated API key or auth credential; potato potato
Summary & Motivation
How I Tested These Changes
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.