Apply Settings to export #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkmin
approved these changes
Aug 28, 2024
| const validStyles = {}; | ||
|
|
||
| const cssValidationRegex = { | ||
| padding: "^(\\d+(px|em|%|rem) ?){1,4}$", |
There was a problem hiding this comment.
Might make sense to put these valid, modifiable css properties in a doc somewhere
There was a problem hiding this comment.
good idea, can add something to the UI customization page
export/index.template.html
Outdated
| ); | ||
| } | ||
|
|
||
| // Validate, sanitize, and apply the styles to the "key-div" textarea. |
There was a problem hiding this comment.
The key-div element is just a simple div, which later gets its innerText set
| @@ -709,6 +836,11 @@ <h2>Message log</h2> | |||
| document.addEventListener( | |||
| "DOMContentLoaded", | |||
| async () => { | |||
| // If styles are saved in local storage, sanitize and apply them. | |||
There was a problem hiding this comment.
You may have already done this, and nothing indicates the contrary, but would be nice to do a sanity check to make sure these loaded settings can be overridden if the user calls applySettings again
There was a problem hiding this comment.
Yes this works as exepected!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for adding css to the export iframe