add optional target length #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkmin
force-pushed
the
andrew/zero-pad-jwk
branch
4 times, most recently
from
3dcfbe3 to
65ea7f8
Compare
andrewkmin
force-pushed
the
andrew/zero-pad-jwk
branch
from
65ea7f8 to
bfae48a
Compare
andrewkmin
commented
Jul 23, 2024
| }) | ||
|
|
||
| it("uncompresses raw P-256 public keys", async () => { | ||
| let uncompressedFrom02 = TKHQ.uncompressRawPublicKey(TKHQ.uint8arrayFromHexString("02c6de3e1d08270d39076651a2b14fd38031dae89892dc124d2f9557816e7e5da4")); | ||
| expect(uncompressedFrom02).toEqual(TKHQ.uint8arrayFromHexString("04c6de3e1d08270d39076651a2b14fd38031dae89892dc124d2f9557816e7e5da4f510c344715f84cf0ba0cc71bd04136c0fb2633a3f459e68ffb8620be16900f0", "hex")); |
There was a problem hiding this comment.
I believe this "hex" parameter was not being used prior
andrewkmin
commented
Jul 23, 2024
| @@ -208,16 +208,23 @@ <h2>Message log</h2> | |||
| }; | |||
|
|
|||
| /** | |||
| * Takes a hex string (e.g. "e4567ab") and returns an array buffer (Uint8Array) | |||
| * Takes a hex string (e.g. "e4567abc") and returns an array buffer (Uint8Array) | |||
There was a problem hiding this comment.
minor: e4567abc is of even-length
r-n-o
reviewed
Jul 23, 2024
auth/index.html
Outdated
| @@ -496,21 +503,22 @@ <h2>Message log</h2> | |||
| /** | |||
| * Converts a `BigInt` into a base64url encoded string | |||
| * @param {BigInt} num | |||
| * @param {number} length: optional expected length of the resulting buffer | |||
There was a problem hiding this comment.
this doesn't return a buffer, it returns a string. So...maybe this is "number of bytes contained in the resulting string"? Tricky tricky.
r-n-o
reviewed
Jul 23, 2024
| * @returns {Uint8Array} | ||
| */ | ||
| var uint8arrayFromHexString = function(hexString) { | ||
| var uint8arrayFromHexString = function(hexString, length) { |
There was a problem hiding this comment.
let's add a test to exercise this new behavior? e.g. uint8arrayFromHexString("0001") (should result in a buffer with a single byte) vs uint8arrayFromHexString("0001", 2) (should result in a buffer with 2 bytes)
r-n-o
approved these changes
Jul 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some randomly generated credentials would not be large enough to fully occupy the expected length of 32 bytes. This is specifically to address an issue where a JWT token would have
d,x, oryvalues that are too short.Here's a sample error message:
Note that this PR does not add similar optionality to other iframes (import/export), since those do not require importing a JWT token.
Sample webcrypto tests can be found here: https://chromium.googlesource.com/chromium/src/+/master/components/test/data/webcrypto/bad_ec_keys.json
Tested locally by: creating a credential that results in a buffer of length 31 for any of the
d,x, orycomponents of the JWT, ensuring that the buffer is padded, and that ultimately the credential can be injected + used to stamp a payload.Screen.Recording.2024-07-23.at.5.03.38.PM.mov