Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate prod and preprod #35

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

andrewkmin
Copy link
Contributor

No description provided.

@james-callahan
Copy link
Contributor

It seems weird that the one docker container is always serving both.

Could you make it an argument when starting the daemon?

Copy link
Collaborator

@r-n-o r-n-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this in is necessary for us to test export on wallet preprod, and it's holding the current release back. So let's merge as-is and we can make separate nginx.conf files for preprod and prod respectively, and then pass these to the daemon with nginx -c <file> via a cmd override in gitops.

@andrewkmin andrewkmin merged commit 2a7d78b into main May 8, 2024
6 checks passed
@andrewkmin andrewkmin deleted the andrew/separate-prod-preprod branch May 8, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants